Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timeseries insertion filters for close samples #3228

Merged

Conversation

gerzse
Copy link
Contributor

@gerzse gerzse commented May 14, 2024

Pull Request check-list

Please make sure to review and check all of these items:

  • Do tests and lints pass with this change?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?
  • Was the change added to CHANGES file?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

Support timeseries insertion filters for samples that are close to each other in time and value.

Use the documented way to disable compression, i.e. ENCODING UNCOMPRESSED instead of UNCOMPRESSED.

Polish the documentation related to timeseries.

Align things needed around CI, to make sure all tests are actually executed.

BREAKING CHANGES:

  1. Remove the uncompressed flag from TS.ALTER, since compression of existing timeseries cannot be changed. This should not have been used, so there should be no real impact.

  2. For the TS.ADD command (TimeSeriesCommands.add method): the duplicate_policy Python parameter that was mapping to ON DUPLICATE was now rewired to map to DUPLICATE POLICY. A new Python parameter called on_duplicate was added, that maps to ON DUPLICATE. The expected impact of this change is low.

Support timeseries insertion filters for samples that are close to each
other in time and value.
@gerzse gerzse requested a review from vladvildanov May 14, 2024 07:13
@gerzse gerzse added the feature New feature label May 21, 2024
@gerzse gerzse added the breakingchange API or Breaking Change label Jun 12, 2024
@gerzse gerzse merged commit 9d85723 into redis:master Jun 12, 2024
47 checks passed
gerzse added a commit to gerzse/redis-py that referenced this pull request Jul 11, 2024
Support timeseries insertion filters for samples that are close to each
other in time and value.

Use the documented way to disable compression, i.e. `ENCODING
UNCOMPRESSED` instead of `UNCOMPRESSED`.

Polish the documentation related to timeseries.

Align things needed around CI, to make sure all tests are actually executed.

BREAKING CHANGES:

1. Remove the `uncompressed` flag from TS.ALTER, since compression of
existing timeseries cannot be changed. This should not have been used, so
there should be no real impact.

2. For the TS.ADD command (TimeSeriesCommands.add method): the
`duplicate_policy` Python parameter that was mapping to
`ON DUPLICATE` was now rewired to map to `DUPLICATE POLICY`.
A new Python parameter called `on_duplicate` was added, that maps to
`ON DUPLICATE`. The expected impact of this change is low.
gerzse added a commit that referenced this pull request Jul 11, 2024
Support timeseries insertion filters for samples that are close to each
other in time and value.

Use the documented way to disable compression, i.e. `ENCODING
UNCOMPRESSED` instead of `UNCOMPRESSED`.

Polish the documentation related to timeseries.

Align things needed around CI, to make sure all tests are actually executed.

BREAKING CHANGES:

1. Remove the `uncompressed` flag from TS.ALTER, since compression of
existing timeseries cannot be changed. This should not have been used, so
there should be no real impact.

2. For the TS.ADD command (TimeSeriesCommands.add method): the
`duplicate_policy` Python parameter that was mapping to
`ON DUPLICATE` was now rewired to map to `DUPLICATE POLICY`.
A new Python parameter called `on_duplicate` was added, that maps to
`ON DUPLICATE`. The expected impact of this change is low.
agnesnatasya pushed a commit to agnesnatasya/redis-py that referenced this pull request Jul 20, 2024
Support timeseries insertion filters for samples that are close to each
other in time and value.

Use the documented way to disable compression, i.e. `ENCODING
UNCOMPRESSED` instead of `UNCOMPRESSED`.

Polish the documentation related to timeseries.

Align things needed around CI, to make sure all tests are actually executed.

BREAKING CHANGES:

1. Remove the `uncompressed` flag from TS.ALTER, since compression of
existing timeseries cannot be changed. This should not have been used, so
there should be no real impact.

2. For the TS.ADD command (TimeSeriesCommands.add method): the
`duplicate_policy` Python parameter that was mapping to
`ON DUPLICATE` was now rewired to map to `DUPLICATE POLICY`.
A new Python parameter called `on_duplicate` was added, that maps to
`ON DUPLICATE`. The expected impact of this change is low.
vladvildanov pushed a commit that referenced this pull request Sep 27, 2024
Support timeseries insertion filters for samples that are close to each
other in time and value.

Use the documented way to disable compression, i.e. `ENCODING
UNCOMPRESSED` instead of `UNCOMPRESSED`.

Polish the documentation related to timeseries.

Align things needed around CI, to make sure all tests are actually executed.

BREAKING CHANGES:

1. Remove the `uncompressed` flag from TS.ALTER, since compression of
existing timeseries cannot be changed. This should not have been used, so
there should be no real impact.

2. For the TS.ADD command (TimeSeriesCommands.add method): the
`duplicate_policy` Python parameter that was mapping to
`ON DUPLICATE` was now rewired to map to `DUPLICATE POLICY`.
A new Python parameter called `on_duplicate` was added, that maps to
`ON DUPLICATE`. The expected impact of this change is low.
vladvildanov pushed a commit that referenced this pull request Sep 27, 2024
Support timeseries insertion filters for samples that are close to each
other in time and value.

Use the documented way to disable compression, i.e. `ENCODING
UNCOMPRESSED` instead of `UNCOMPRESSED`.

Polish the documentation related to timeseries.

Align things needed around CI, to make sure all tests are actually executed.

BREAKING CHANGES:

1. Remove the `uncompressed` flag from TS.ALTER, since compression of
existing timeseries cannot be changed. This should not have been used, so
there should be no real impact.

2. For the TS.ADD command (TimeSeriesCommands.add method): the
`duplicate_policy` Python parameter that was mapping to
`ON DUPLICATE` was now rewired to map to `DUPLICATE POLICY`.
A new Python parameter called `on_duplicate` was added, that maps to
`ON DUPLICATE`. The expected impact of this change is low.
vladvildanov pushed a commit that referenced this pull request Sep 27, 2024
Support timeseries insertion filters for samples that are close to each
other in time and value.

Use the documented way to disable compression, i.e. `ENCODING
UNCOMPRESSED` instead of `UNCOMPRESSED`.

Polish the documentation related to timeseries.

Align things needed around CI, to make sure all tests are actually executed.

BREAKING CHANGES:

1. Remove the `uncompressed` flag from TS.ALTER, since compression of
existing timeseries cannot be changed. This should not have been used, so
there should be no real impact.

2. For the TS.ADD command (TimeSeriesCommands.add method): the
`duplicate_policy` Python parameter that was mapping to
`ON DUPLICATE` was now rewired to map to `DUPLICATE POLICY`.
A new Python parameter called `on_duplicate` was added, that maps to
`ON DUPLICATE`. The expected impact of this change is low.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breakingchange API or Breaking Change feature New feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants