Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub Workflows security hardening #2444

Merged
merged 5 commits into from
Nov 21, 2022
Merged

GitHub Workflows security hardening #2444

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d97a564
build: harden pypi-publish.yaml permissions
sashashura Nov 3, 2022
ac90dfb
build: harden stale-issues.yml permissions
sashashura Nov 3, 2022
40cf016
build: harden release-drafter.yml permissions
sashashura Nov 3, 2022
e84f1d7
build: harden integration.yaml permissions
sashashura Nov 3, 2022
af61db2
Merge branch 'master' into patch-1
chayim Nov 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
build: harden release-drafter.yml permissions 
Signed-off-by: Alex <aleksandrosansan@gmail.com>
  • Loading branch information
@sashashura
sashashura committed Nov 3, 2022
commit 40cf0163bbda188d58f03d02ac2d25a07f70daa6
5 changes: 5 additions & 0 deletions .github/workflows/release-drafter.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,13 @@ on:
branches:
- master

permissions: {}
jobs:
update_release_draft:
permissions:
pull-requests: write # to add label to PR (release-drafter/release-drafter)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the drafter need this permission? We don't use it to add permissions, rather rely on the permissions set in the PR. WDYT?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are the permissions the author documented as needed in the readme https://github.com/release-drafter/release-drafter/blob/6df64e4ba4842c203c604c1f45246c5863410adb/README.md?plain=1#L35-L39
Note, that pull-requests permission can be read-only if autolabeler is not used.

We don't use it to add permissions, rather rely on the permissions set in the PR.

I'm not sure I understand the question. The lines do not add new permissions, the default ones are write to all. The lines remove everything not explicitly mentioned.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I.e. the workflow runs on push, not on pull-request with write to all permissions.

contents: write # to create a github release (release-drafter/release-drafter)

runs-on: ubuntu-latest
steps:
# Drafts your next Release notes as Pull Requests are merged into "master"
Expand Down