Replace OSError exceptions from can_read with redis.ConnectionError
#2140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2140 +/- ##
=======================================
Coverage 92.44% 92.44%
=======================================
Files 104 104
Lines 24385 24393 +8
=======================================
+ Hits 22542 22550 +8
Misses 1843 1843
Continue to review full report at Codecov.
|
kristjanvalur
force-pushed
the
pr-can_read
branch
from
6d5c1d4 to
b5d5c30
Compare
|
@kristjanvalur I tried to push an update to your branch, to fix the linters. Can you run the following to fix your linting? Then we can merge! |
chayim
reviewed
Apr 27, 2022
redis/asyncio/connection.py
Outdated
| except OSError as e: | ||
| await self.disconnect() | ||
| raise ConnectionError( | ||
| f"Error while reading from {self.host}:{self.port} : {e.args}" |
There was a problem hiding this comment.
Nice. Small nit to remove a space.
f"Error while reading from {self.host}:{self.port}: {e.args}"
chayim
reviewed
Apr 27, 2022
redis/connection.py
Outdated
| return self._parser.can_read(timeout) | ||
| except OSError as e: | ||
| self.disconnect() | ||
| raise ConnectionError(f"Error while reading from {self.host}:{self.port} : {e.args}") |
There was a problem hiding this comment.
Same
f"Error while reading from {self.host}:{self.port}: {e.args}"
chayim
suggested changes
Apr 27, 2022
dvora-h
approved these changes
May 3, 2022
chayim
approved these changes
May 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request check-list
Please make sure to review and check all of these items:
$ toxpass with this change (including linting)?NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.
Description of change
This change catches OS errors in
Connection.can_read, closes connection and raises aredis.ConnectionError.Fixes #2138