Skip to content

Fix anchor links in README #1746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Fix anchor links in README #1746

wants to merge 1 commit into from

Conversation

gdalmau
Copy link

@gdalmau gdalmau commented Nov 24, 2021

Pull Request check-list

Please make sure to review and check all of these items:

  • Does $ tox pass with this change (including linting)?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

The anchor links in the README don't seem to work. Removing one # should fix it.

@gdalmau gdalmau changed the title Fix anchor links Fix anchor links in README Nov 24, 2021
@chayim
Copy link
Contributor

chayim commented Nov 24, 2021

@gdalmau Thank you so much for contributing this! I've already got it fixed, and queued up for tomorrow (literally), in this PR.

@gdalmau
Copy link
Author

gdalmau commented Nov 24, 2021

@chayim Oh I see 😄 then I will close it.

Superseded by #1743

@gdalmau gdalmau closed this Nov 24, 2021
@gdalmau gdalmau deleted the patch-1 branch November 24, 2021 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants