Skip to content

Unit tests fixes for compatibility #1703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Nov 14, 2021
Merged

Unit tests fixes for compatibility #1703

merged 12 commits into from
Nov 14, 2021

Conversation

chayim
Copy link
Contributor

@chayim chayim commented Nov 14, 2021

  • Fixing multiprocessing tests to respect redisurl ports
  • Test improvement: do not fill modules information if no modules present
  • Marking module loader as redismod
  • Database override support
  • Pubsub test fix
  • Enterprise tests support
  • Test validation and skips
  • Skips for redis enterprise
  • Adding support for redis command COMMAND

@chayim chayim changed the title ck enterprise Unit tests fixes for compatibility Nov 14, 2021
@codecov-commenter
Copy link

codecov-commenter commented Nov 14, 2021

Codecov Report

Merging #1703 (bbcf19d) into master (e881976) will increase coverage by 0.06%.
The diff coverage is 85.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1703      +/-   ##
==========================================
+ Coverage   89.01%   89.07%   +0.06%     
==========================================
  Files          53       53              
  Lines       11083    11071      -12     
==========================================
- Hits         9865     9862       -3     
+ Misses       1218     1209       -9     
Impacted Files Coverage Δ
tests/conftest.py 93.50% <50.00%> (+0.60%) ⬆️
redis/commands/redismodules.py 85.71% <66.66%> (+7.93%) ⬆️
redis/client.py 82.26% <92.85%> (-0.14%) ⬇️
redis/commands/core.py 83.88% <100.00%> (+0.02%) ⬆️
redis/commands/search/__init__.py 81.81% <100.00%> (-0.54%) ⬇️
redis/commands/timeseries/__init__.py 100.00% <100.00%> (ø)
tests/test_commands.py 93.14% <100.00%> (+0.01%) ⬆️
tests/test_connection.py 72.00% <100.00%> (-8.56%) ⬇️
redis/sentinel.py 87.17% <0.00%> (+0.64%) ⬆️
redis/connection.py 71.46% <0.00%> (+0.64%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e881976...bbcf19d. Read the comment docs.

@chayim chayim added the maintenance Maintenance (CI, Releases, etc) label Nov 14, 2021
@chayim chayim merged commit 19819e0 into master Nov 14, 2021
@chayim chayim deleted the ck-enterprise branch November 14, 2021 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Maintenance (CI, Releases, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants