add type checking for graph __eq__ (#2531)

redis · Jan 8, 2023 · c7600b4 · c7600b4
1 parent decd1f6
commit c7600b4
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 0 deletions.
diff --git a/redis/commands/graph/edge.py b/redis/commands/graph/edge.py
@@ -61,6 +61,10 @@ def __str__(self):
         return res
 
     def __eq__(self, rhs):
+        # Type checking
+        if not isinstance(rhs, Edge):
+            return False
+
         # Quick positive check, if both IDs are set.
         if self.id is not None and rhs.id is not None and self.id == rhs.id:
             return True

diff --git a/redis/commands/graph/node.py b/redis/commands/graph/node.py
@@ -65,6 +65,10 @@ def __str__(self):
         return res
 
     def __eq__(self, rhs):
+        # Type checking
+        if not isinstance(rhs, Node):
+            return False
+
         # Quick positive check, if both IDs are set.
         if self.id is not None and rhs.id is not None and self.id != rhs.id:
             return False

diff --git a/redis/commands/graph/path.py b/redis/commands/graph/path.py
@@ -54,6 +54,10 @@ def add_edge(self, edge):
         return self
 
     def __eq__(self, other):
+        # Type checking
+        if not isinstance(other, Path):
+            return False
+
         return self.nodes() == other.nodes() and self.edges() == other.edges()
 
     def __str__(self):