Skip to content

Commit 6f55c63

Browse files
committed
Skip testing resp3 parsing for async/py3.7
1 parent 6f8b44a commit 6f55c63

File tree

2 files changed

+7
-4
lines changed

2 files changed

+7
-4
lines changed

tests/test_asyncio/test_connect.py

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22
import logging
33
import socket
44
import ssl
5+
import sys
56
from unittest.mock import patch
67

78
import pytest
@@ -19,6 +20,7 @@
1920

2021

2122
_CLIENT_NAME = "test-suite-client"
23+
PY37 = sys.version_info[:2] == (3, 7)
2224

2325

2426
@pytest.fixture
@@ -76,15 +78,17 @@ async def test_tcp_ssl_connect(tcp_address):
7678
(6, 3, False, True),
7779
(6, 3, True, True),
7880
],
81+
ids=["server-ver", "resp-ver", "use-auth", "cli-name"],
7982
)
80-
# @pytest.mark.parametrize("use_protocol", [2, 3])
81-
# @pytest.mark.parametrize("use_auth", [False, True])
8283
async def test_tcp_auth(
8384
tcp_address, use_protocol, use_auth, use_server_ver, use_client_name
8485
):
8586
"""
8687
Test that various initial handshake cases are handled correctly by the client
8788
"""
89+
if use_protocol == 3 and PY37:
90+
pytest.skip("Python 3.7 does not support protocol 3 for asyncio")
91+
8892
got_auth = []
8993
got_protocol = None
9094
got_name = None

tests/test_connect.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -74,9 +74,8 @@ def test_tcp_ssl_connect(tcp_address):
7474
(6, 3, False, True),
7575
(6, 3, True, True),
7676
],
77+
ids=["server-ver", "resp-ver", "use-auth", "cli-name"],
7778
)
78-
# @pytest.mark.parametrize("use_protocol", [2, 3])
79-
# @pytest.mark.parametrize("use_auth", [False, True])
8079
def test_tcp_auth(tcp_address, use_protocol, use_auth, use_server_ver, use_client_name):
8180
"""
8281
Test that various initial handshake cases are handled correctly by the client

0 commit comments

Comments
 (0)