Skip to content

Commit

Permalink
Revert "Skip testing resp3 parsing for async/py3.7", now that parsing…
Browse files Browse the repository at this point in the history
… is fixed.

This reverts commit 09b51d4.
  • Loading branch information
kristjanvalur committed Nov 13, 2023
1 parent 09b51d4 commit 5a79252
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 5 deletions.
7 changes: 2 additions & 5 deletions tests/test_asyncio/test_connect.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
import logging
import socket
import ssl
import sys
from unittest.mock import patch

import pytest
Expand All @@ -20,7 +19,6 @@


_CLIENT_NAME = "test-suite-client"
PY37 = sys.version_info[:2] == (3, 7)


@pytest.fixture
Expand Down Expand Up @@ -79,15 +77,14 @@ async def test_tcp_ssl_connect(tcp_address):
(6, 3, True, True),
],
)
# @pytest.mark.parametrize("use_protocol", [2, 3])
# @pytest.mark.parametrize("use_auth", [False, True])
async def test_tcp_auth(
tcp_address, use_protocol, use_auth, use_server_ver, use_client_name
):
"""
Test that various initial handshake cases are handled correctly by the client
"""
if use_protocol == 3 and PY37:
pytest.skip("Python 3.7 does not support protocol 3 for asyncio")

got_auth = []
got_protocol = None
got_name = None
Expand Down
2 changes: 2 additions & 0 deletions tests/test_connect.py
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,8 @@ def test_tcp_ssl_connect(tcp_address):
(6, 3, True, True),
],
)
# @pytest.mark.parametrize("use_protocol", [2, 3])
# @pytest.mark.parametrize("use_auth", [False, True])
def test_tcp_auth(tcp_address, use_protocol, use_auth, use_server_ver, use_client_name):
"""
Test that various initial handshake cases are handled correctly by the client
Expand Down

0 comments on commit 5a79252

Please sign in to comment.