Skip to content

enhancement: find().count() #313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

enhancement: find().count() #313

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
5be5c52
ignore pycharm env
tomcounsell Jul 14, 2022
17c71fa
fix imports on test hash model
tomcounsell Jul 18, 2022
ee3fd30
delete when exists keys to delete
tomcounsell Jul 18, 2022
ea171a8
count method
tomcounsell Jul 18, 2022
a0dec58
test count method
tomcounsell Jul 18, 2022
730d339
add basic all test and count assertions
tomcounsell Jul 19, 2022
33af908
fix import refs
tomcounsell Jul 19, 2022
15dd2ee
count method returns int
tomcounsell Jul 19, 2022
e9909a3
expect bytestring
tomcounsell Jul 19, 2022
4d63c40
remove temp test file
tomcounsell Jul 19, 2022
381ab0e
sum the counts
tomcounsell Jul 19, 2022
efdca3c
don't test sort_by with count
tomcounsell Jul 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
delete when exists keys to delete
  • Loading branch information
@tomcounsell
tomcounsell committed Jul 18, 2022
commit ee3fd302bfc9f3a9ea661fdbde04332cd8cd6ad4
5 changes: 4 additions & 1 deletion aredis_om/model/model.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -792,7 +792,10 @@ async def update(self, use_transaction=True, **field_values):
async def delete(self):
"""Delete all matching records in this query."""
# TODO: Better response type, error detection
return await self.model.db().delete(*[m.key() for m in await self.all()])
keys_to_delete = [m.key() for m in await self.all()]
if not keys_to_delete:
return 0
return await self.model.db().delete(*keys_to_delete)

async def __aiter__(self):
if self._model_cache:
Expand Down