Skip to content

In case of unexpected failure on process_self_contained_coordinator_stream we log it and recover #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 16, 2022

Conversation

filipecosta90
Copy link
Contributor

Fixes #81

@filipecosta90 filipecosta90 added bug Something isn't working tool-self-coordinator Tooling changes: Self contained coordinator labels Feb 16, 2022
@filipecosta90 filipecosta90 force-pushed the get_final_benchmark_config.fix branch from 8fa67c0 to 8d69028 Compare February 16, 2022 12:33
@codecov-commenter
Copy link

Codecov Report

Merging #82 (5753e3e) into main (82d8b3c) will decrease coverage by 12.73%.
The diff coverage is 38.93%.

Impacted file tree graph

@@             Coverage Diff             @@
##             main      #82       +/-   ##
===========================================
- Coverage   76.92%   64.19%   -12.74%     
===========================================
  Files          14       16        +2     
  Lines         871     1131      +260     
===========================================
+ Hits          670      726       +56     
- Misses        201      405      +204     
Impacted Files Coverage Δ
...is_benchmarks_specification/__builder__/builder.py 74.70% <0.00%> (-0.45%) ⬇️
redis_benchmarks_specification/__runner__/args.py 10.34% <10.34%> (ø)
...edis_benchmarks_specification/__runner__/runner.py 22.32% <22.32%> (ø)
...chmarks_specification/__common__/builder_schema.py 82.08% <50.00%> (-0.99%) ⬇️
...tained_coordinator__/self_contained_coordinator.py 72.11% <79.09%> (-1.80%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d574882...5753e3e. Read the comment docs.

@filipecosta90 filipecosta90 merged commit 221ece5 into main Feb 16, 2022
@filipecosta90 filipecosta90 deleted the get_final_benchmark_config.fix branch February 16, 2022 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working tool-self-coordinator Tooling changes: Self contained coordinator
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]: __self_contained_coordinator__ error in process_self_contained_coordinator_stream
2 participants