Skip to content

Extended logging for action:trigger-benchmark #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 6, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
71 changes: 30 additions & 41 deletions poetry.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[tool.poetry]
name = "redis-benchmarks-specification"
version = "0.1.17"
version = "0.1.18"
description = "The Redis benchmarks specification describes the cross-language/tools requirements and expectations to foster performance and observability standards around redis related technologies. Members from both industry and academia, including organizations and individuals are encouraged to contribute."
authors = ["filipecosta90 <filipecosta.90@gmail.com>","Redis Performance Group <performance@redis.com>"]
readme = "Readme.md"
Expand All @@ -24,6 +24,7 @@ GitPython = "^3.1.20"
redistimeseries = "1.4.3"
semver = "^2.13.0"
node-semver = "^0.8.1"
typed-ast = "^1.5.0"

[tool.poetry.dev-dependencies]
black = "20.8b1"
Expand Down
4 changes: 4 additions & 0 deletions redis_benchmarks_specification/__api__/app.py
Original file line number Diff line number Diff line change
Expand Up @@ -76,13 +76,17 @@ def base():
html_url = repo_dict["html_url"].split("/")
gh_repo = html_url[-1]
gh_org = html_url[-2]
detected_label = False
for label in labels:
label_name = label["name"]
if trigger_label == label_name:
use_event = True
event_type = "Pull request labeled with '{}'".format(
trigger_label
)
detected_label = True
if detected_label is False:
app.logger.info("Unable to detected benchmark trigger label: {}".format(trigger_label))

# Git pushes to repo
if "ref" in request_data:
Expand Down
2 changes: 1 addition & 1 deletion redis_benchmarks_specification/__common__/env.py
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@

# environment variables
PULL_REQUEST_TRIGGER_LABEL = os.getenv(
"PULL_REQUEST_TRIGGER_LABEL", "trigger-benchmark"
"PULL_REQUEST_TRIGGER_LABEL", "action:run-benchmark"
)
DATASINK_RTS_PUSH = bool(os.getenv("DATASINK_PUSH_RTS", False))
DATASINK_RTS_AUTH = os.getenv("DATASINK_RTS_AUTH", None)
Expand Down