Add memtier benchmark with mixed SET/GET operations with short exp time #294
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulorsousa
requested review from
Copilot and
fcostaoliveira
and removed request for
Copilot
paulorsousa
changed the title
There was a problem hiding this comment.
Pull Request Overview
Adds a new memtier benchmark configuration for a mixed 50% SET / 50% GET workload with short expiration on a 1 M-key dataset and 400 concurrent connections.
- Introduces a new YAML test suite file defining both preload and client workloads.
- Specifies resource requests and Redis topologies for standalone and IO-thread variants.
- Sets benchmark parameters (data size, expiration, pipeline, test time) and priority.
| preload_tool: | ||
| run_image: redislabs/memtier_benchmark:edge | ||
| tool: memtier_benchmark | ||
| arguments: '--pipeline 100 --data-size 240 --command "SET __key__ __data__ EX 5" --command-key-pattern P -c 50 -t 2 --hide-histogram --key-minimum 1' |
There was a problem hiding this comment.
There are two spaces between --key-minimum and 1, which may cause parsing issues. Consider removing the extra space for consistency.
Suggested change
| arguments: '--pipeline 100 --data-size 240 --command "SET __key__ __data__ EX 5" --command-key-pattern P -c 50 -t 2 --hide-histogram --key-minimum 1' | |
| arguments: '--pipeline 100 --data-size 240 --command "SET __key__ __data__ EX 5" --command-key-pattern P -c 50 -t 2 --hide-histogram --key-minimum 1' |
Copilot uses AI. Check for mistakes.
| clientconfig: | ||
| run_image: redislabs/memtier_benchmark:edge | ||
| tool: memtier_benchmark | ||
| arguments: --command "SET __key__ __data__ EX 5" --command "GET __key__" -c 50 -t 8 --hide-histogram --test-time 120 |
There was a problem hiding this comment.
[nitpick] The arguments field here is unquoted, unlike the dbconfig section, leading to inconsistent YAML style and potential parsing surprises. Consider quoting the entire argument string to match the other block.
Suggested change
| arguments: --command "SET __key__ __data__ EX 5" --command "GET __key__" -c 50 -t 8 --hide-histogram --test-time 120 | |
| arguments: "--command \"SET __key__ __data__ EX 5\" --command \"GET __key__\" -c 50 -t 8 --hide-histogram --test-time 120" |
Copilot uses AI. Check for mistakes.
paulorsousa
force-pushed
the
feat/add-testsuite-50-50-set-get-with-expiration
branch
from
06ea814 to
3df92c3
Compare
fcostaoliveira
approved these changes
May 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.