Skip to content

Fix for TypeError in self-coordinator #224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 10, 2023
Merged

Conversation

markovamaria
Copy link
Collaborator

@markovamaria markovamaria commented Mar 28, 2023

Fix for "TypeError" (see below) includes replacement of exec_init_command function from redis-admin branch to similar (but newer) function in redis-benchmark-specification branch.
redis-* test syntax was aligned to others tests for passing CI rules

Error:

  File "/root/venv-redis/lib/python3.8/site-packages/redis_benchmarks_specification/__self_contained_coordinator__/self_contained_coordinator.py", line 560, in process_self_contained_coordinator_stream
    execute_init_commands(
  File "/root/venv-redis/lib/python3.8/site-packages/redisbench_admin/run/common.py", line 426, in execute_init_commands
    cmds = k["init_commands"]
TypeError: string indices must be integers

How to reproduce:

Run on testing host:

$ redis-benchmarks-spec-sc-coordinator --platform-name intel64-ubuntu20.04-biredis --event_stream_host benchmarks.redislabs.com --event_stream_port <redacted> --event_stream_pass <redacted> --event_stream_user default --datasink_push_results_redistimeseries --datasink_redistimeseries_host benchmarks.redislabs.com --datasink_redistimeseries_port 12011 --datasink_redistimeseries_pass <redacted> --logname /var/opt/test2.log --redis_proc_start_port 6379 --cpuset_start_pos 0 --docker-air-gap --consumer-id 1

In parallell run testing's triggering:

redis-benchmarks-spec-cli --use-branch --from-date 2023-03-22 --redis_port 12010 --redis_host benchmarks.redislabs.com --redis_pass ***

@codecov-commenter
Copy link

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.01 🎉

Comparison is base (a4fa679) 56.74% compared to head (dd782cc) 56.76%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #224      +/-   ##
==========================================
+ Coverage   56.74%   56.76%   +0.01%     
==========================================
  Files          24       24              
  Lines        2224     2225       +1     
==========================================
+ Hits         1262     1263       +1     
  Misses        962      962              
Impacted Files Coverage Δ
...tained_coordinator__/self_contained_coordinator.py 58.35% <ø> (ø)
...edis_benchmarks_specification/__common__/runner.py 84.70% <100.00%> (+0.18%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Replaced usage of redisbench_admin.run.common.execute_init_commands to newer redis_benchmarks_specification.__common__.runner.execute_init_commands
@markovamaria
Copy link
Collaborator Author

Hi @filipecosta90 , please take a look

@markovamaria markovamaria self-assigned this Apr 7, 2023
@filipecosta90
Copy link
Contributor

Thank you @markovamaria ! Merging

@filipecosta90 filipecosta90 merged commit 80710ad into main Apr 10, 2023
@filipecosta90 filipecosta90 deleted the execute_init_usage branch April 10, 2023 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants