Skip to content

Added conversion for str for git timestamps #216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 26, 2023
Merged

Added conversion for str for git timestamps #216

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0922207
Added conversion for str for git timestamps
markovamaria Feb 22, 2023
b7f2c55
Removed unused variable in stats.py to satisfy 'flake8' rule
markovamaria Feb 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion redis_benchmarks_specification/__cli__/cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ def get_commits(args, repo):
"git_hash": commit.hexsha,
"git_branch": repo.active_branch.name,
"commit_summary": commit.summary,
"commit_datetime": commit_datetime,
"commit_datetime": str(commit_datetime),
}
)
return commits, total_commits
Expand Down
3 changes: 0 additions & 3 deletions redis_benchmarks_specification/__cli__/stats.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -338,9 +338,6 @@ def generate_stats_cli_command_logic(args, project_name, project_version):
logging.warn("Unable to detect group in {}".format(cmd))

priority_list = sorted(((priority[cmd], cmd) for cmd in priority), reverse=True)
priority_list_usecs = sorted(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@markovamaria why was this removed?

Copy link
Collaborator Author

@markovamaria markovamaria Feb 23, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@markovamaria why was this removed?

It is assigned, but never used. This line causing fail in .tox tools.

Fail in actions in here: https://github.com/redis/redis-benchmarks-specification/actions/runs/4246038262
image

Manual repro:

$ .tox/integration-tests/bin/flake8 redis_benchmarks_specification 
redis_benchmarks_specification/__cli__/stats.py:341:9: F841 local variable 'priority_list_usecs' is assigned to but never used

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@markovamaria why was this removed?
I agree that it is separate issue. :) But it blocked CI for this commit

((priority_usecs[cmd], cmd) for cmd in priority_usecs), reverse=True
)

priority_json = {}
top_10_missing = []
Expand Down