Skip to content

Update timestamp conversion in client #210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

markovamaria
Copy link
Collaborator

@markovamaria markovamaria commented Feb 8, 2023

Reverting of str converting for "timestamp" to avoid error "str object has no attribute timestamp"
Resolves: #209

@markovamaria
Copy link
Collaborator Author

@filipecosta90 , looks like CI failure related to " aws-region: ${{ secrets.AWS_REGION }} " line in yml file, could you please help me to resolve it?

@slice4e
Copy link
Collaborator

slice4e commented Feb 8, 2023

@filipecosta90 , looks like CI failure related to " aws-region: ${{ secrets.AWS_REGION }} " line in yml file, could you please help me to resolve it?

@markovamaria This is because you are doing the pull request from markovamaria fork. Instead, work directly in the main fork.
In other words, make a pull request into redis:main from redis:cli_timestamp_fix.

@markovamaria
Copy link
Collaborator Author

added PR w/o fork #211

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]: Failure of "redis-benchmarks-spec-cli" for retriggering of CI
2 participants