Skip to content

Enabled --cluster-mode in client runner #199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 23, 2023
Merged

Enabled --cluster-mode in client runner #199

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions redis_benchmarks_specification/__runner__/args.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,4 +190,10 @@ def create_client_runner_args(project_name):
type=int,
help="override memtier number of runs for each benchmark. By default will run once each test",
)
parser.add_argument(
"--cluster-mode",
default=False,
action="store_true",
help="Run client in cluster mode.",
)
return parser
9 changes: 6 additions & 3 deletions redis_benchmarks_specification/__runner__/runner.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -410,7 +410,7 @@ def process_self_contained_coordinator_stream(
port = args.db_server_port
host = args.db_server_host
password = args.db_server_password

oss_cluster_api_enabled = args.cluster_mode
ssl_cert_reqs = "required"
if tls_skip_verify:
ssl_cert_reqs = None
Expand Down Expand Up @@ -553,6 +553,7 @@ def process_self_contained_coordinator_stream(
test_tls_cacert,
resp_version,
password,
oss_cluster_api_enabled,
)
execute_init_commands(
benchmark_config, r, dbconfig_keyname="dbconfig"
Expand Down Expand Up @@ -596,6 +597,7 @@ def process_self_contained_coordinator_stream(
local_benchmark_output_filename
)
)

if "memtier_benchmark" not in benchmark_tool:
# prepare the benchmark command
(
Expand All @@ -622,7 +624,7 @@ def process_self_contained_coordinator_stream(
host,
password,
local_benchmark_output_filename,
False,
oss_cluster_api_enabled,
tls_enabled,
tls_skip_verify,
test_tls_cert,
Expand Down Expand Up @@ -970,6 +972,7 @@ def data_prepopulation_step(
tls_cacert=None,
resp_version=None,
password=None,
oss_cluster_api_enabled=False,
):
# setup the benchmark
(
Expand Down Expand Up @@ -999,7 +1002,7 @@ def data_prepopulation_step(
host,
password,
local_benchmark_output_filename,
False,
oss_cluster_api_enabled,
tls_enabled,
tls_skip_verify,
tls_cert,
Expand Down