Skip to content

Validated SPEC fields uppon PR and commit #173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Dec 8, 2022
Merged

Conversation

filipecosta90
Copy link
Contributor

This PR ensures all benchmark fields include some minimum fields like command name, group, etc...

@codecov-commenter
Copy link

Codecov Report

Base: 59.66% // Head: 59.35% // Decreases project coverage by -0.30% ⚠️

Coverage data is based on head (9d7ea80) compared to base (512da9a).
Patch coverage: 8.33% of modified lines in pull request are covered.

❗ Current head 9d7ea80 differs from pull request most recent head 3604079. Consider uploading reports for the commit 3604079 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #173      +/-   ##
==========================================
- Coverage   59.66%   59.35%   -0.31%     
==========================================
  Files          24       24              
  Lines        1800     1811      +11     
==========================================
+ Hits         1074     1075       +1     
- Misses        726      736      +10     
Impacted Files Coverage Δ
redis_benchmarks_specification/__cli__/stats.py 5.03% <0.00%> (-0.34%) ⬇️
redis_benchmarks_specification/__cli__/args.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@filipecosta90 filipecosta90 merged commit 20fd146 into main Dec 8, 2022
@filipecosta90 filipecosta90 deleted the validate-spec-fields branch December 8, 2022 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants