Skip to content

Avoid RDB usage on unit tests #145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 7, 2022
Merged

Avoid RDB usage on unit tests #145

merged 3 commits into from
Dec 7, 2022

Conversation

filipecosta90
Copy link
Contributor

@filipecosta90 filipecosta90 commented Nov 29, 2022

Full test run now takes around 4min.


=============================================================================== 25 passed, 252 warnings in 219.57s (0:03:39) ===============================================================================
integration-tests run-test: commands[4] | coverage report -m
Name                                                                                          Stmts   Miss  Cover   Missing
---------------------------------------------------------------------------------------------------------------------------
redis_benchmarks_specification/__api__/__init__.py                                                0      0   100%
redis_benchmarks_specification/__api__/app.py                                                   118     17    86%   46-49, 54, 59-67, 76, 78, 115
redis_benchmarks_specification/__builder__/__init__.py                                            0      0   100%
redis_benchmarks_specification/__builder__/builder.py                                           186     54    71%   54-141, 163-164, 186, 213, 224-241, 254, 280, 326, 357, 365-371, 408-414, 423
redis_benchmarks_specification/__builder__/schema.py                                             13      0   100%
redis_benchmarks_specification/__cli__/__init__.py                                                0      0   100%
redis_benchmarks_specification/__cli__/args.py                                                   31      0   100%
redis_benchmarks_specification/__cli__/cli.py                                                   111     47    58%   44-55, 85, 99-111, 126, 141-172, 175, 188, 196-211, 225-259
redis_benchmarks_specification/__cli__/stats.py                                                 149    141     5%   19-223
redis_benchmarks_specification/__common__/__init__.py                                             0      0   100%
redis_benchmarks_specification/__common__/builder_schema.py                                      86     11    87%   53, 81-86, 103-106, 114, 151
redis_benchmarks_specification/__common__/env.py                                                 45      1    98%   79
redis_benchmarks_specification/__common__/package.py                                             19     11    42%   10-21
redis_benchmarks_specification/__common__/runner.py                                              30      0   100%
redis_benchmarks_specification/__common__/spec.py                                                22      0   100%
redis_benchmarks_specification/__init__.py                                                        6      2    67%   14-15
redis_benchmarks_specification/__runner__/__init__.py                                             0      0   100%
redis_benchmarks_specification/__runner__/args.py                                                35      0   100%
redis_benchmarks_specification/__runner__/runner.py                                             280    105    62%   56-64, 69-70, 106-114, 129-137, 200-202, 247-248, 275, 298-305, 326-336, 341, 367, 389, 465-556, 571-580, 583-593, 597, 602-603, 623-632, 636-642, 654-672, 679-688, 709-773
redis_benchmarks_specification/__self_contained_coordinator__/__init__.py                         0      0   100%
redis_benchmarks_specification/__self_contained_coordinator__/args.py                            31     28    10%   25-138
redis_benchmarks_specification/__self_contained_coordinator__/artifacts.py                       12      0   100%
redis_benchmarks_specification/__self_contained_coordinator__/build_info.py                      36      2    94%   20, 36
redis_benchmarks_specification/__self_contained_coordinator__/clients.py                          8      0   100%
redis_benchmarks_specification/__self_contained_coordinator__/cpuset.py                          11      0   100%
redis_benchmarks_specification/__self_contained_coordinator__/docker.py                          27     14    48%   37-46, 59-90
redis_benchmarks_specification/__self_contained_coordinator__/prepopulation.py                   22     14    36%   28-86
redis_benchmarks_specification/__self_contained_coordinator__/runners.py                        191    154    19%   88-89, 119-611
redis_benchmarks_specification/__self_contained_coordinator__/self_contained_coordinator.py     318    128    60%   91-225, 282, 314, 322, 348, 397-403, 414-419, 475-484, 558, 685-760, 767, 822-840, 855-864, 876-886, 968-973
redis_benchmarks_specification/__setups__/__init__.py                                             0      0   100%
redis_benchmarks_specification/__setups__/topologies.py                                          13      0   100%
---------------------------------------------------------------------------------------------------------------------------
TOTAL                                                                                          1800    729    60%
integration-tests docker: remove 'cd0892554a' (from 'datasink')
integration-tests docker: remove '533700e425' (from 'db_server')
_________________________________________________________________________________________________ summary __________________________________________________________________________________________________
  integration-tests: commands succeeded
  congratulations :)

@filipecosta90 filipecosta90 changed the title Speedup builder tests Avoid RDB usage on unit tests Dec 6, 2022
@codecov-commenter
Copy link

Codecov Report

Base: 54.09% // Head: 59.66% // Increases project coverage by +5.57% 🎉

Coverage data is based on head (1488d9e) compared to base (913d682).
Patch coverage: 33.33% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #145      +/-   ##
==========================================
+ Coverage   54.09%   59.66%   +5.57%     
==========================================
  Files          23       24       +1     
  Lines        1588     1800     +212     
==========================================
+ Hits          859     1074     +215     
+ Misses        729      726       -3     
Impacted Files Coverage Δ
...ecification/__self_contained_coordinator__/args.py 9.67% <0.00%> (-0.33%) ⬇️
redis_benchmarks_specification/__cli__/stats.py 5.36% <5.36%> (ø)
...tained_coordinator__/self_contained_coordinator.py 59.74% <27.27%> (-1.17%) ⬇️
...fication/__self_contained_coordinator__/runners.py 19.37% <28.57%> (+0.34%) ⬆️
redis_benchmarks_specification/__cli__/cli.py 57.65% <33.33%> (-1.23%) ⬇️
...edis_benchmarks_specification/__runner__/runner.py 62.50% <53.12%> (+43.16%) ⬆️
...is_benchmarks_specification/__builder__/builder.py 72.58% <100.00%> (-0.06%) ⬇️
redis_benchmarks_specification/__cli__/args.py 100.00% <100.00%> (ø)
...chmarks_specification/__common__/builder_schema.py 87.20% <100.00%> (+3.62%) ⬆️
...edis_benchmarks_specification/__common__/runner.py 100.00% <100.00%> (+72.22%) ⬆️
... and 6 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@filipecosta90 filipecosta90 merged commit 512da9a into main Dec 7, 2022
@filipecosta90 filipecosta90 deleted the builder.asserts branch December 7, 2022 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants