Client Side Caching #2947
Merged
Client Side Caching #2947
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nkaradzhov
reviewed
May 7, 2025
htemelski
reviewed
May 7, 2025
bobymicroby
force-pushed
the
csc-sjpotter
branch
7 times, most recently
from
778c629 to
7fd7686
Compare
bobymicroby
force-pushed
the
csc-sjpotter
branch
4 times, most recently
from
334bb72 to
92c900b
Compare
htemelski
approved these changes
May 16, 2025
nkaradzhov
approved these changes
May 19, 2025
packages/client/lib/client/cache.ts
Outdated
Comment on lines
351
to
341
| recordEvictions(count: number): void { | ||
| this.#evictionCount++; | ||
| } |
There was a problem hiding this comment.
should this increment by count?
The `CacheStats` class provides detailed metrics like hit/miss counts, load success/failure counts, total load time, and eviction counts. It also offers derived metrics such as hit/miss rates, load failure rate, and average load penalty. The design is inspired by Caffeine. `BasicClientSideCache` now uses a `StatsCounter` to accumulate these statistics, exposed via a new `stats()` method. The previous `cacheHits()` and `cacheMisses()` methods have been removed. A `recordStats` option (default: true) in `ClientSideCacheConfig` allows disabling statistics collection.
|
Hey @andy-stark-redis, we have client-side caching in node-redis now. Bobi included some useful docs you can use. |
|
@elena-kolevska Hi! Yeah, I've been following this PR and I've already started the docs for CSC. I'll let Bobi know when the docs PR is ready for review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.