-
Notifications
You must be signed in to change notification settings - Fork 1.9k
fix #2458 - add support for WAITAOF
#2536
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## master #2536 +/- ##
==========================================
- Coverage 95.70% 95.68% -0.02%
==========================================
Files 456 457 +1
Lines 4561 4564 +3
Branches 524 524
==========================================
+ Hits 4365 4367 +2
- Misses 127 128 +1
Partials 69 69
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good, some small changes are needed..
Thanks for contributing!
wait: WAIT | ||
wait: WAIT, | ||
WAITAOF, | ||
waitaof: WAITAOF |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change to waitAOF
or waitAof
(I'm actually not sure which one we should go with :P)
[1, 0] | ||
); | ||
}, GLOBAL.SERVERS.OPEN); | ||
}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add an empty line
]; | ||
} | ||
|
||
export declare function transformReply(): Array<[number, number]>; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add an empty line
@leibale Thanks for reviewing! I make some changes according to your feedback. Please take a look whenever you have time. |
WAITAOF
Description
Fix #2458
Checklist
npm test
pass with this change (including linting)?