Skip to content

Add support for CommandOptions in all ScanIterators #2382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

shacharPash
Copy link
Contributor

@shacharPash shacharPash commented Jan 19, 2023

fix #2370

shacharPash and others added 2 commits January 19, 2023 19:13
@codecov-commenter
Copy link

codecov-commenter commented Jan 19, 2023

Codecov Report

Base: 95.85% // Head: 93.58% // Decreases project coverage by -2.28% ⚠️

Coverage data is based on head (607726d) compared to base (abf2b4b).
Patch coverage: 100.00% of modified lines in pull request are covered.

❗ Current head 607726d differs from pull request most recent head 3511995. Consider uploading reports for the commit 3511995 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2382      +/-   ##
==========================================
- Coverage   95.85%   93.58%   -2.28%     
==========================================
  Files         451      451              
  Lines        4247     4253       +6     
  Branches      475      477       +2     
==========================================
- Hits         4071     3980      -91     
- Misses        106      206     +100     
+ Partials       70       67       -3     
Impacted Files Coverage Δ
packages/client/lib/client/index.ts 91.01% <100.00%> (-0.99%) ⬇️
packages/client/lib/commands/FUNCTION_LOAD.ts 16.66% <0.00%> (-83.34%) ⬇️
packages/client/lib/commands/FUNCTION_FLUSH.ts 20.00% <0.00%> (-80.00%) ⬇️
packages/client/lib/commands/FUNCTION_RESTORE.ts 20.00% <0.00%> (-80.00%) ⬇️
packages/client/lib/commands/CLIENT_NO-EVICT.ts 33.33% <0.00%> (-66.67%) ⬇️
packages/client/lib/commands/FUNCTION_LIST.ts 37.50% <0.00%> (-62.50%) ⬇️
packages/client/lib/commands/FUNCTION_STATS.ts 25.00% <0.00%> (-62.50%) ⬇️
packages/client/lib/commands/LCS_IDX.ts 50.00% <0.00%> (-50.00%) ⬇️
packages/client/lib/commands/LCS_LEN.ts 50.00% <0.00%> (-50.00%) ⬇️
packages/client/lib/commands/SINTERCARD.ts 50.00% <0.00%> (-50.00%) ⬇️
... and 25 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@shacharPash shacharPash marked this pull request as ready for review February 8, 2023 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add option returnBuffers=true to the various ScanIterators
3 participants