Skip to content

Commit b9e50e4

Browse files
committed
fix(client): Return null to mimic v5 api
1 parent 0d8d05e commit b9e50e4

File tree

2 files changed

+21
-10
lines changed

2 files changed

+21
-10
lines changed

packages/client/lib/commands/generic-transformers.spec.ts

Lines changed: 14 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -197,10 +197,19 @@ describe('Generic Transformers', () => {
197197
describe('transformStreamMessagesReply', () => {
198198
it('with null', () => {
199199
assert.deepEqual(
200-
transformStreamMessagesReply([null]),
201-
[]
200+
transformStreamMessagesReply([null, ['0-0', ['0key', '0value']]]),
201+
[null, {
202+
id: '0-0',
203+
message: Object.create(null, {
204+
'0key': {
205+
value: '0value',
206+
configurable: true,
207+
enumerable: true
208+
}
209+
})
210+
}]
202211
);
203-
})
212+
});
204213

205214
it('with messages', () => {
206215
assert.deepEqual(
@@ -225,8 +234,8 @@ describe('Generic Transformers', () => {
225234
})
226235
}]
227236
);
228-
})
229-
})
237+
});
238+
});
230239

231240
describe('transformStreamsMessagesReply', () => {
232241
it('null', () => {

packages/client/lib/commands/generic-transformers.ts

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -92,16 +92,18 @@ export interface StreamMessageReply {
9292
message: Record<string, RedisCommandArgument>;
9393
}
9494

95-
export type StreamMessagesReply = Array<StreamMessageReply>;
95+
export type StreamMessagesReply = Array<StreamMessageReply | null>;
9696

9797
export function transformStreamMessagesReply(reply: Array<any>): StreamMessagesReply {
9898
const messages = [];
9999

100-
if (reply[0] === null) {
101-
return messages;
102-
}
100+
for (const tuple of reply) {
101+
if (tuple === null) {
102+
messages.push(null);
103+
continue;
104+
}
103105

104-
for (const [id, message] of reply) {
106+
const [id, message] = tuple;
105107
messages.push({
106108
id,
107109
message: transformTuplesReply(message)

0 commit comments

Comments
 (0)