Remove deprecated methods (blpop, brpop, pexpire) #902
Conversation
There was a problem hiding this comment.
This guys weren't marked as @Deprecated but I believe there is no problem to delete it since JedisCommands marked it as @Deprecated. 👍
There was a problem hiding this comment.
Oh, that's right. Thanks for finding!
Btw, we can do the trick, adding @deprecated to methods and apply it to 2.7.
There was a problem hiding this comment.
I agree with that. Do you want me to do it or you gonna do by yourself?
There was a problem hiding this comment.
Oh, that would be nice. Could you do it if you don't mind?
Thanks in advance!
There was a problem hiding this comment.
Sure. Doing it.
Jungtaek Lim notifications@github.com escreveu no dia ter, 3/03/2015 às
11:23:
In src/main/java/redis/clients/jedis/JedisCluster.java
#902 (comment):@@ -1089,26 +1089,6 @@ public Long execute(Jedis connection) {
}
- public List blpop(final String arg) {
Oh, that would be nice. Could you do it if you don't mind?
Thanks in advance!—
Reply to this email directly or view it on GitHub
https://github.com/xetorthio/jedis/pull/902/files#r25690235.
|
Just added a note but it looks good to me. 👍 |
|
We should apply this to (Binary)JedisCluster when #671 will be merged into mater. |
|
@HeartSaVioR can you please rebase so it can be merged? Thx!. |
Conflicts: src/main/java/redis/clients/jedis/BinaryJedis.java src/main/java/redis/clients/jedis/BinaryShardedJedis.java src/main/java/redis/clients/jedis/JedisCluster.java
|
@marcosnils Sure! Here it is. :) |
Remove deprecated methods (blpop, brpop, pexpire)
3 participants
Removed all deprecated methods in master branch.