Supports Multi Key commands to JedisCluster #673
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello.
As supporting Redis Cluster work, I implemented Cluster multi key commands based on previous interfaces.
During implementing, I found that some commands are fine with Redis, but maybe some commands are not fine with Redis Cluster.
(Actually there're no documentation from Redis describing cluster-able commands.)
So I removed some suspicious commands from interface, and introduced new interfaces for Jedis Cluster.
(Please let me know when you think something is wrong.)
Below is the commands I removed from previous interfaces.
BinaryJedisClusterCommands (copied from BinaryCommands)
MultiKeyBinaryJedisClusterCommands (copied from MultiKeyBinaryCommands)
JedisClusterCommands (copied from JedisCommands)
MultiKeyJedisClusterCommands (copied from MultiKeyCommands)
And I introduce some utils and exception, you can find it from commit log.
Please review and comment so that this PR goes to cluster-revised.
Thanks!