Bump JDK version to 1.8 #2357
Closed
Bump JDK version to 1.8 #2357
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Inspired by redis#1334 where this went real easy :). Would have made redis#2355 shorter. Free public updates for JDK 7 ended in 2015: <https://en.wikipedia.org/wiki/Java_version_history> For JDK 8, free public support is available from non-Orace vendors until at least 2026 according to the same table. And JDK 8 is what Jedis is being tested on anyway: <https://github.com/redis/jedis/blob/ac0969315655180c09b8139c16bded09c068d498/.circleci/config.yml#L67-L74>
Contributor
|
@walles Include the change in your actual PR. |
Contributor
Author
|
I just saw that 3.5.1 recently released by @gkorland is already being built with Java 8: https://github.com/redis/jedis/releases/tag/jedis-3.5.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by #1334 where this went real easy :).
Would have made #2355 shorter.
Free public updates for JDK 7 ended in 2015:
https://en.wikipedia.org/wiki/Java_version_history
For JDK 8, free public support is available from non-Oracle vendors until at least 2026 according to the same table.
And JDK 8 is what Jedis is being tested on anyway:
jedis/.circleci/config.yml
Lines 67 to 74 in ac09693