catch JedisDataException during pipeline sync #1783
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The method client.getOne() should be called enough times even if JedisDataException is thrown, otherwise the next commands sent to server via the same connection may be crashed due to the remaining responses in its receive buffer.
Contributor
|
@QooYoung Change looks good. But it would be much more helpful with proper tests. Would you be able to add some tests? |
This was referenced Apr 6, 2021
Contributor
|
@sazzad16 Does this PR can slove this question #2488 (comment) which you metioned. |
Contributor
|
@yangbodong22011 No.
I meant that this PR approaches an issue related to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The method client.getOne() should be called enough times even if JedisDataException is thrown, otherwise the next commands sent to server via the same connection may be crashed due to the remaining responses in its receive buffer.