Reduce code redundancy #1705
Merged
Reduce code redundancy #1705
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
Contributor
|
Nice refactor LGTM! |
Contributor
Author
|
@marcosnils Just added a small change. Please check again. |
Contributor
Author
|
Merged into master. |
sazzad16
added a commit
that referenced
this pull request
Dec 12, 2017
* Reduce code redundancy * Safer/independent String.equals() Conflicts: src/main/java/redis/clients/jedis/JedisClusterInfoCache.java src/main/java/redis/clients/jedis/JedisPool.java src/main/java/redis/clients/jedis/JedisShardInfo.java Changes to be committed: modified: src/main/java/redis/clients/jedis/BinaryJedis.java modified: src/main/java/redis/clients/jedis/Connection.java modified: src/main/java/redis/clients/jedis/JedisClusterInfoCache.java modified: src/main/java/redis/clients/jedis/JedisFactory.java modified: src/main/java/redis/clients/jedis/JedisPool.java modified: src/main/java/redis/clients/jedis/JedisSentinelPool.java modified: src/main/java/redis/clients/jedis/JedisShardInfo.java modified: src/main/java/redis/clients/util/JedisURIHelper.java
Contributor
Author
|
Backported to 2.10 with deprecation. |
joyang1
pushed a commit
to joyang1/jedis
that referenced
this pull request
Dec 27, 2018
* Reduce code redundancy * Safer/independent String.equals()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JedisPool