Added initial size for HashMaps #1343
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
LGTM. Great finding. |
Contributor
|
Yeah I forgot we might release 2.8.x. :) |
| public Map<String, String> build(Object data) { | ||
| final List<byte[]> flatHash = (List<byte[]>) data; | ||
| final Map<String, String> hash = new HashMap<String, String>(); | ||
| final Map<String, String> hash = new HashMap<String, String>(flatHash.size()/2); |
Contributor
There was a problem hiding this comment.
You might want to add load factor 1 as you already know the target size in advance. Load factor 1 prevents rehashing. Same for the change below.
Contributor
|
LGTM after addressing @mp911de comments. |
… resized when Redis Hash has too many keys.
Contributor
Author
|
Added load factor |
Contributor
|
Amazing! Good catch! LGTM! |
marcosnils
pushed a commit
that referenced
this pull request
Jul 14, 2016
… resized when Redis Hash has too many keys. (#1343)
Contributor
|
Merged. Applied to 2.8 and 2.9 respectively. |
marcosnils
pushed a commit
that referenced
this pull request
Jul 14, 2016
… resized when Redis Hash has too many keys. (#1343)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid it being resized when Redis Hash has too many keys.