Skip to content

Commit d584951

Browse files
committed
Merge branch 'cluster-revised' into cluster-support-multi-key-new
Conflicts: src/main/java/redis/clients/jedis/BinaryJedisCluster.java src/main/java/redis/clients/jedis/JedisCluster.java
2 parents 4a9b82a + 18308d1 commit d584951

File tree

159 files changed

+28382
-28801
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

159 files changed

+28382
-28801
lines changed

.travis.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,5 +3,6 @@ jdk:
33
- openjdk6
44
- openjdk7
55
- oraclejdk7
6+
- oraclejdk8
67
install: make travis-install
78
script: make test

CONTRIBUTING.md

Lines changed: 56 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,56 @@
1+
# How to use Jedis Github Issue
2+
3+
* Github issues SHOULD ONLY BE USED to report bugs, and for DETAILED feature requests. Everything else belongs to the Jedis Google Group.
4+
5+
Jedis Google Group address:
6+
7+
https://groups.google.com/forum/?fromgroups#!forum/jedis_redis
8+
9+
Please post General questions to Google Group. It can be closed without answer when posted to Github issue.
10+
11+
# Some rules of Jedis source code
12+
13+
## Code Convention
14+
15+
* Jedis uses ```HBase Formatter``` introduced by [HBASE-5961](https://issues.apache.org/jira/browse/HBASE-5961)
16+
* You can import code style file (located to hbase-formatter.xml) to Eclipse, IntelliJ
17+
* line break by column count seems not working with IntelliJ
18+
* You can run ```make format``` anytime to reformat without IDEs
19+
20+
## Adding commands
21+
22+
* Jedis uses many interfaces to structure commands
23+
* planned to write documentation about it, contribution is more welcome!
24+
* We need to add commands to all interfaces which have responsibility to expose
25+
* ex) We need to add ping() command to BasicCommands, and provide implementation to all of classes which implemented BasicCommands
26+
27+
## type <-> byte array conversion
28+
29+
* string <-> byte array : use SafeEncoder.encode()
30+
* Caution: use String.toBytes() directly will break GBK support!
31+
* boolean, int, long, double -> byte array : use Protocol.toByteArray()
32+
33+
# How to contribute by Pull Request
34+
35+
1. Fork Jedis on github (http://help.github.com/fork-a-repo/)
36+
2. Create a topic branch (git checkout -b my_branch)
37+
3. Push to your branch (git push origin my_branch)
38+
4. Post a pull request on github (http://help.github.com/send-pull-requests/)
39+
40+
I recommend you to create branch with meaningful name, not modifying master branch directly.
41+
42+
Please add unit tests in order to prove your modification works smoothly. And please make sure your modification passes all unit tests.
43+
44+
# Jedis Test Environment
45+
46+
Jedis unit tests run with latest [```Redis unstable branch```](https://github.com/antirez/redis).
47+
Please let them prepared and installed.
48+
49+
Jedis unit tests use many Redis instances, so we use ```Makefile``` to prepare environment.
50+
51+
You can start test with ```make test```.
52+
You can set up test environments by ```make start```, and tear down environments by ```make stop```.
53+
54+
If one or some of unit tests in current master branch of Jedis fails with Redis unstable branch, please post it to Github issue, and go ahead with other unit tests at your work.
55+
56+
Thanks!

Makefile

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -289,11 +289,14 @@ deploy:
289289
mvn clean deploy
290290
make stop
291291

292+
format:
293+
mvn java-formatter:format
294+
292295
release:
293296
make start
294297
mvn release:clean
295298
mvn release:prepare
296-
mvn release:perform
299+
mvn release:perform -DskipTests
297300
make stop
298301

299302
travis-install:

README.md

Lines changed: 20 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ Or use it as a maven dependency:
4848
<dependency>
4949
<groupId>redis.clients</groupId>
5050
<artifactId>jedis</artifactId>
51-
<version>2.6.0</version>
51+
<version>2.6.2</version>
5252
<type>jar</type>
5353
<scope>compile</scope>
5454
</dependency>
@@ -81,23 +81,32 @@ jc.set("foo", "bar");
8181
String value = jc.get("foo");
8282
```
8383

84-
## I want to contribute!
84+
## FAQ
85+
86+
- Do you have strange stack traces?
87+
- You're getting errors when running jedis in multi-threaded environments?
88+
- Do you need further instructions about pipelining, transactions or sentinel?
8589

86-
That is great! Just fork the project in github. Create a topic branch, write some code, and add some tests for your new code.
90+
Please check the [WIKI](https://github.com/xetorthio/jedis/wiki) for more useful information.
8791

88-
To run the tests:
8992

90-
- Use the latest redis master branch.
93+
## I want to contribute!
94+
95+
That is great!
9196

92-
- Run ```make test```. This will run 2 instances of redis. We use 2 redis
93-
servers, one on default port (6379) and the other one on (6380). Both have
94-
authentication enabled with default password (foobared). This way we can
95-
test both sharding and auth command. For the Sentinel tests to we use a
96-
default Sentinel configuration that is configured to properly authenticate
97-
using the same password with a master called mymaster running on 6379.
97+
Please see CONTRIBUTING.md on project's root directory for follow up how to contribute to Jedis project.
9898

9999
Thanks for helping!
100100

101+
## Sponsorship
102+
103+
YourKit supports open source projects with its full-featured Java Profiler.
104+
YourKit, LLC is the creator of [YourKit Java Profiler](http://www.yourkit.com/java/profiler/index.jsp)
105+
and [YourKit .NET Profiler](http://www.yourkit.com/.net/profiler/index.jsp),
106+
innovative and intelligent tools for profiling Java and .NET applications.
107+
108+
![YourKit Logo](https://cloud.githubusercontent.com/assets/1317309/4507430/7119527c-4b0c-11e4-9245-d72e751e26ee.png)
109+
101110
## License
102111

103112
Copyright (c) 2011 Jonathan Leibiusky

build.gradle

Lines changed: 0 additions & 33 deletions
This file was deleted.

gradle/wrapper/gradle-wrapper.jar

-49.3 KB
Binary file not shown.

gradle/wrapper/gradle-wrapper.properties

Lines changed: 0 additions & 6 deletions
This file was deleted.

gradlew

Lines changed: 0 additions & 164 deletions
This file was deleted.

0 commit comments

Comments
 (0)