Skip to content

Commit 4fb5121

Browse files
authored
Rename xpendingSummary to xpending (#2458)
Because there is no conflict while maintaining Redis command name.
1 parent 8b75067 commit 4fb5121

17 files changed

+78
-77
lines changed

src/main/java/redis/clients/jedis/BinaryClient.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1764,6 +1764,10 @@ public void xreadGroup(byte[] groupname, byte[] consumer, final XReadGroupParams
17641764
sendCommand(XREADGROUP, args);
17651765
}
17661766

1767+
public void xpending(final byte[] key, final byte[] groupname) {
1768+
sendCommand(XPENDING, key, groupname);
1769+
}
1770+
17671771
public void xpending(byte[] key, byte[] groupname, byte[] start, byte[] end, int count,
17681772
byte[] consumername) {
17691773
if (consumername == null) {
@@ -1773,10 +1777,6 @@ public void xpending(byte[] key, byte[] groupname, byte[] start, byte[] end, int
17731777
}
17741778
}
17751779

1776-
public void xpendingSummary(final byte[] key, final byte[] groupname) {
1777-
sendCommand(XPENDING, key, groupname);
1778-
}
1779-
17801780
public void xclaim(byte[] key, byte[] groupname, byte[] consumername, long minIdleTime,
17811781
long newIdleTime, int retries, boolean force, byte[][] ids) {
17821782

src/main/java/redis/clients/jedis/BinaryJedis.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4651,9 +4651,9 @@ public List<Object> xpending(byte[] key, byte[] groupname, byte[] start, byte[]
46514651
}
46524652

46534653
@Override
4654-
public Object xpendingSummary(final byte[] key, final byte[] groupname) {
4654+
public Object xpending(final byte[] key, final byte[] groupname) {
46554655
checkIsInMultiOrPipeline();
4656-
client.xpendingSummary(key, groupname);
4656+
client.xpending(key, groupname);
46574657
return client.getOne();
46584658
}
46594659

src/main/java/redis/clients/jedis/BinaryJedisCluster.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2568,11 +2568,11 @@ public List<Object> execute(Jedis connection) {
25682568
}
25692569

25702570
@Override
2571-
public Object xpendingSummary(final byte[] key, final byte[] groupname) {
2571+
public Object xpending(final byte[] key, final byte[] groupname) {
25722572
return new JedisClusterCommand<Object>(connectionHandler, maxAttempts) {
25732573
@Override
25742574
public Object execute(Jedis connection) {
2575-
return connection.xpendingSummary(key, groupname);
2575+
return connection.xpending(key, groupname);
25762576
}
25772577
}.runBinary(key);
25782578
}

src/main/java/redis/clients/jedis/BinaryShardedJedis.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1201,9 +1201,9 @@ public List<Object> xpending(byte[] key, byte[] groupname, byte[] start, byte[]
12011201
}
12021202

12031203
@Override
1204-
public Object xpendingSummary(final byte[] key, final byte[] groupname) {
1204+
public Object xpending(final byte[] key, final byte[] groupname) {
12051205
Jedis j = getShard(key);
1206-
return j.xpendingSummary(key, groupname);
1206+
return j.xpending(key, groupname);
12071207
}
12081208

12091209
@Override

src/main/java/redis/clients/jedis/Client.java

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1491,18 +1491,18 @@ public void xreadGroup(String groupname, String consumer, XReadGroupParams param
14911491
sendCommand(Protocol.Command.XREADGROUP, args);
14921492
}
14931493

1494+
@Override
1495+
public void xpending(String key, String groupname) {
1496+
xpending(SafeEncoder.encode(key), SafeEncoder.encode(groupname));
1497+
}
1498+
14941499
@Override
14951500
public void xpending(String key, String groupname, StreamEntryID start, StreamEntryID end,
14961501
int count, String consumername) {
14971502
xpending(SafeEncoder.encode(key), SafeEncoder.encode(groupname), SafeEncoder.encode(start==null ? "-" : start.toString()),
14981503
SafeEncoder.encode(end==null ? "+" : end.toString()), count, consumername == null? null : SafeEncoder.encode(consumername));
14991504
}
15001505

1501-
@Override
1502-
public void xpendingSummary(String key, String groupname) {
1503-
xpendingSummary(SafeEncoder.encode(key), SafeEncoder.encode(groupname));
1504-
}
1505-
15061506
@Override
15071507
public void xclaim(String key, String group, String consumername, long minIdleTime,
15081508
long newIdleTime, int retries, boolean force, StreamEntryID... ids) {

src/main/java/redis/clients/jedis/Jedis.java

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -4231,18 +4231,18 @@ public List<Map.Entry<String, List<StreamEntry>>> xreadGroup(final String groupn
42314231
}
42324232

42334233
@Override
4234-
public List<StreamPendingEntry> xpending(final String key, final String groupname,
4235-
final StreamEntryID start, final StreamEntryID end, final int count, final String consumername) {
4234+
public StreamPendingSummary xpending(final String key, final String groupname) {
42364235
checkIsInMultiOrPipeline();
4237-
client.xpending(key, groupname, start, end, count, consumername);
4238-
return BuilderFactory.STREAM_PENDING_ENTRY_LIST.build(client.getObjectMultiBulkReply());
4236+
client.xpending(key, groupname);
4237+
return BuilderFactory.STREAM_PENDING_SUMMARY.build(client.getObjectMultiBulkReply());
42394238
}
42404239

42414240
@Override
4242-
public StreamPendingSummary xpendingSummary(final String key, final String groupname) {
4241+
public List<StreamPendingEntry> xpending(final String key, final String groupname,
4242+
final StreamEntryID start, final StreamEntryID end, final int count, final String consumername) {
42434243
checkIsInMultiOrPipeline();
4244-
client.xpendingSummary(key, groupname);
4245-
return BuilderFactory.STREAM_PENDING_SUMMARY.build(client.getObjectMultiBulkReply());
4244+
client.xpending(key, groupname, start, end, count, consumername);
4245+
return BuilderFactory.STREAM_PENDING_ENTRY_LIST.build(client.getObjectMultiBulkReply());
42464246
}
42474247

42484248
@Override

src/main/java/redis/clients/jedis/JedisCluster.java

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -2629,22 +2629,22 @@ public List<Entry<String, List<StreamEntry>>> execute(Jedis connection) {
26292629
}
26302630

26312631
@Override
2632-
public List<StreamPendingEntry> xpending(final String key, final String groupname,
2633-
final StreamEntryID start, final StreamEntryID end, final int count, final String consumername) {
2634-
return new JedisClusterCommand<List<StreamPendingEntry>>(connectionHandler, maxAttempts) {
2632+
public StreamPendingSummary xpending(final String key, final String groupname) {
2633+
return new JedisClusterCommand<StreamPendingSummary>(connectionHandler, maxAttempts) {
26352634
@Override
2636-
public List<StreamPendingEntry> execute(Jedis connection) {
2637-
return connection.xpending(key, groupname, start, end, count, consumername);
2635+
public StreamPendingSummary execute(Jedis connection) {
2636+
return connection.xpending(key, groupname);
26382637
}
26392638
}.run(key);
26402639
}
26412640

26422641
@Override
2643-
public StreamPendingSummary xpendingSummary(final String key, final String groupname) {
2644-
return new JedisClusterCommand<StreamPendingSummary>(connectionHandler, maxAttempts) {
2642+
public List<StreamPendingEntry> xpending(final String key, final String groupname,
2643+
final StreamEntryID start, final StreamEntryID end, final int count, final String consumername) {
2644+
return new JedisClusterCommand<List<StreamPendingEntry>>(connectionHandler, maxAttempts) {
26452645
@Override
2646-
public StreamPendingSummary execute(Jedis connection) {
2647-
return connection.xpendingSummary(key, groupname);
2646+
public List<StreamPendingEntry> execute(Jedis connection) {
2647+
return connection.xpending(key, groupname, start, end, count, consumername);
26482648
}
26492649
}.run(key);
26502650
}

src/main/java/redis/clients/jedis/PipelineBase.java

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -2223,6 +2223,18 @@ public Response<Long> xgroupDelConsumer(byte[] key, byte[] groupname, byte[] con
22232223
return getResponse(BuilderFactory.LONG);
22242224
}
22252225

2226+
@Override
2227+
public Response<StreamPendingSummary> xpending(String key, String groupname) {
2228+
getClient(key).xpending(key, groupname);
2229+
return getResponse(BuilderFactory.STREAM_PENDING_SUMMARY);
2230+
}
2231+
2232+
@Override
2233+
public Response<Object> xpending(byte[] key, byte[] groupname) {
2234+
getClient(key).xpending(key, groupname);
2235+
return getResponse(BuilderFactory.RAW_OBJECT);
2236+
}
2237+
22262238
@Override
22272239
public Response<List<StreamPendingEntry>> xpending(String key, String groupname,
22282240
StreamEntryID start, StreamEntryID end, int count, String consumername) {
@@ -2244,18 +2256,6 @@ public Response<List<Object>> xpendingBinary(byte[] key, byte[] groupname, byte[
22442256
return getResponse(BuilderFactory.RAW_OBJECT_LIST);
22452257
}
22462258

2247-
@Override
2248-
public Response<StreamPendingSummary> xpendingSummary(String key, String groupname) {
2249-
getClient(key).xpendingSummary(key, groupname);
2250-
return getResponse(BuilderFactory.STREAM_PENDING_SUMMARY);
2251-
}
2252-
2253-
@Override
2254-
public Response<Object> xpendingSummary(byte[] key, byte[] groupname) {
2255-
getClient(key).xpendingSummary(key, groupname);
2256-
return getResponse(BuilderFactory.RAW_OBJECT);
2257-
}
2258-
22592259
@Override
22602260
public Response<Long> xdel(String key, StreamEntryID... ids) {
22612261
getClient(key).xdel(key, ids);

src/main/java/redis/clients/jedis/ShardedJedis.java

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1190,16 +1190,16 @@ public List<StreamEntry> xrevrange(String key, StreamEntryID end, StreamEntryID
11901190
}
11911191

11921192
@Override
1193-
public List<StreamPendingEntry> xpending(String key, String groupname, StreamEntryID start,
1194-
StreamEntryID end, int count, String consumername) {
1193+
public StreamPendingSummary xpending(String key, String groupname) {
11951194
Jedis j = getShard(key);
1196-
return j.xpending(key, groupname, start, end, count, consumername);
1195+
return j.xpending(key, groupname);
11971196
}
11981197

11991198
@Override
1200-
public StreamPendingSummary xpendingSummary(String key, String groupname) {
1199+
public List<StreamPendingEntry> xpending(String key, String groupname, StreamEntryID start,
1200+
StreamEntryID end, int count, String consumername) {
12011201
Jedis j = getShard(key);
1202-
return j.xpendingSummary(key, groupname);
1202+
return j.xpending(key, groupname, start, end, count, consumername);
12031203
}
12041204

12051205
@Override

src/main/java/redis/clients/jedis/commands/BinaryJedisClusterCommands.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -411,9 +411,9 @@ List<GeoRadiusResponse> georadiusByMemberReadonly(byte[] key, byte[] member, dou
411411

412412
Long xtrim(byte[] key, long maxLen, boolean approximateLength);
413413

414-
List<Object> xpending(byte[] key, byte[] groupname, byte[] start, byte[] end, int count, byte[] consumername);
414+
Object xpending(final byte[] key, final byte[] groupname);
415415

416-
Object xpendingSummary(final byte[] key, final byte[] groupname);
416+
List<Object> xpending(byte[] key, byte[] groupname, byte[] start, byte[] end, int count, byte[] consumername);
417417

418418
List<byte[]> xclaim(byte[] key, byte[] groupname, byte[] consumername, long minIdleTime, long newIdleTime, int retries, boolean force, byte[][] ids);
419419

0 commit comments

Comments
 (0)