Deprecate SENTINEL SLAVES and change tests (#2673)

Author: sazzad16

src/main/java/redis/clients/jedis/Jedis.java

@@ -3515,9 +3515,25 @@ public Long sentinelReset(final String pattern) {
     return client.getIntegerReply();
   }
 
+  /**
+   * @deprecated Use {@link Jedis#sentinelReplicas(java.lang.String)}.
+   */
+  @Override
+  @Deprecated
+  public List<Map<String, String>> sentinelSlaves(final String masterName) {
+    client.sentinel(Protocol.SENTINEL_SLAVES, masterName);
+    final List<Object> reply = client.getObjectMultiBulkReply();
+
+    final List<Map<String, String>> slaves = new ArrayList<>();
+    for (Object obj : reply) {
+      slaves.add(BuilderFactory.STRING_MAP.build(obj));
+    }
+    return slaves;
+  }
+
   /**
    * <pre>
-   * redis 127.0.0.1:26381&gt; sentinel slaves mymaster
+   * redis 127.0.0.1:26381&gt; sentinel replicas mymaster
    * 1)  1) "name"
    *     2) "127.0.0.1:6380"
    *     3) "ip"
@@ -3550,18 +3566,6 @@ public Long sentinelReset(final String pattern) {
    * @param masterName
    * @return
    */
-  @Override
-  public List<Map<String, String>> sentinelSlaves(final String masterName) {
-    client.sentinel(Protocol.SENTINEL_SLAVES, masterName);
-    final List<Object> reply = client.getObjectMultiBulkReply();
-
-    final List<Map<String, String>> slaves = new ArrayList<>();
-    for (Object obj : reply) {
-      slaves.add(BuilderFactory.STRING_MAP.build(obj));
-    }
-    return slaves;
-  }
-
   @Override
   public List<Map<String, String>> sentinelReplicas(final String masterName) {
     client.sentinel(SentinelKeyword.REPLICAS, masterName);

src/main/java/redis/clients/jedis/commands/SentinelCommands.java

@@ -17,6 +17,10 @@ public interface SentinelCommands {
 
   Long sentinelReset(String pattern);
 
+  /**
+   * @deprecated Use {@link SentinelCommands#sentinelReplicas(java.lang.String)}.
+   */
+  @Deprecated
   List<Map<String, String>> sentinelSlaves(String masterName);
 
   List<Map<String, String>> sentinelReplicas(String masterName);

src/test/java/redis/clients/jedis/tests/JedisSentinelTest.java

@@ -65,7 +65,7 @@ public void sentinel() {
           Integer.parseInt(masterHostAndPort.get(1)));
       assertEquals(master, masterFromSentinel);
 
-      List<Map<String, String>> slaves = j.sentinelSlaves(MASTER_NAME);
+      List<Map<String, String>> slaves = j.sentinelReplicas(MASTER_NAME);
       assertTrue(!slaves.isEmpty());
       assertEquals(master.getPort(), Integer.parseInt(slaves.get(0).get("master-port")));
 

src/test/java/redis/clients/jedis/tests/commands/SentinelCommandsTest.java

@@ -49,17 +49,10 @@ public void masterMasters() {
   }
 
   @Test
-  public void replicasSlaves() {
-    String runId;
+  public void replicas() {
     try (Jedis sentinel = new Jedis(sentinel2_1)) {
       Map<String, String> details = sentinel.sentinelReplicas("mymaster").get(0);
       assertEquals(Integer.toString(replica2.getPort()), details.get("port"));
-      runId = details.get("runid");
-    }
-
-    try (Jedis sentinel2 = new Jedis(sentinel2_2)) {
-      Map<String, String> details = sentinel2.sentinelSlaves("mymaster").get(0);
-      assertEquals(runId, details.get("runid"));
     }
   }
 }