Fix pool to close all connections when client is closed. #97
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| // Full reports whether list is full. If list is not full the caller must add or | ||
| // remove connection from the pool. | ||
| func (l *connList) Full() bool { |
There was a problem hiding this comment.
Minor: how about calling this method Reserve? Seems like it would better reflect the purpose.
There was a problem hiding this comment.
Thanks, sounds much better.
|
Looked over briefly, can't see anything obvious: 👍 |
vmihailenco
force-pushed
the
fix/pool-closes-all-connections
branch
from
0fc3506 to
f3f44ae
Compare
vmihailenco
added a commit
that referenced
this pull request
May 5, 2015
Fix pool to close all connections when client is closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is very useful when you want application to exit gracefully. Existing
BenchmarkPoolnumbers are not changed.Pool was refactored a bit since I want to reuse it in go-pg/pg#52
/cc @dim