add readOnly on failover opts #3281

smilad · 2025-02-18T19:43:24Z

fixing issues :
#3277

adding ReadOnly for scenarios where you need to connect to read-only replicas is not supported in UniversalClient

by adding this I can connect to readOnly and Master separately

add failover that if is True it connects to slaves

ndyakov · 2025-02-19T08:27:34Z

Hello @smilad, thank you for the contribution. Would you please add a test for the change that you are introducing in this PR?

smilad · 2025-02-19T13:26:13Z

@ndyakov :
Done

ndyakov · 2025-02-20T14:07:05Z

@smilad The test you added is skipped and won't be executed. Can we have a test that will be executed and validate the new option?

smilad · 2025-02-22T07:32:39Z

@ndyakov : it is because of your sentinel options
and pipelines have problems
the first test case also has this issue
but if run test on local it is ok

ndyakov · 2025-02-24T10:51:15Z

@smilad lets work together on making sure we can execute the desired test in CI. Looking at your change, having a test that tries to write to a read only client should result in an error. We can test for that? Also we can make sure we are connected to a replica. Correct?

ndyakov · 2025-02-26T09:51:49Z

@smilad i can see a binary that needs to be removed from the changes. Also, let's enable the test and work on making it pass.

oryxBuildBinary

ndyakov

enable test

universal_test.go

enable previously skipped test.

ndyakov · 2025-02-26T15:48:46Z

@smilad I see your point about the CI, there are some changes coming in the following weeks that should enable you to write tests agains sentinels. Are you OK with waiting #3274 to be merged before we can work on merging this one?

smilad · 2025-02-27T20:32:21Z

@ndyakov
it didn't fixed
You must add slaves too
in code if replicas was empty it connect to masterAddr
you just add some master sentinel

universal_test.go

don't run sentinel test in RE

smilad · 2025-03-01T19:09:10Z

@ndyakov
Is it ok to merge?

ndyakov · 2025-03-04T11:37:53Z

@smilad should be, can you please fix the formatting(indentations) on the test?

universal_test.go

This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [github.com/redis/go-redis/v9](https://github.com/redis/go-redis) | require | minor | `v9.7.3` -> `v9.8.0` | --- ### Release Notes <details> <summary>redis/go-redis (github.com/redis/go-redis/v9)</summary> ### [`v9.8.0`](https://github.com/redis/go-redis/releases/tag/v9.8.0) [Compare Source](redis/go-redis@v9.7.3...v9.8.0) ### 9.8.0 (2025-04-30) #### 🚀 Highlights - **Redis 8 Support**: Full compatibility with Redis 8.0, including testing and CI integration - **Enhanced Hash Operations**: Added support for new hash commands (`HGETDEL`, `HGETEX`, `HSETEX`) and `HSTRLEN` command - **Search Improvements**: Enabled Search DIALECT 2 by default and added `CountOnly` argument for `FT.Search` #### ✨ New Features - Added support for new hash commands: `HGETDEL`, `HGETEX`, `HSETEX` ([#3305](redis/go-redis#3305)) - Added `HSTRLEN` command for hash operations ([#2843](redis/go-redis#2843)) - Added `Do` method for raw query by single connection from `pool.Conn()` ([#3182](redis/go-redis#3182)) - Prevent false-positive marshaling by treating zero time.Time as empty in isEmptyValue ([#3273](redis/go-redis#3273)) - Added FailoverClusterClient support for Universal client ([#2794](redis/go-redis#2794)) - Added support for cluster mode with `IsClusterMode` config parameter ([#3255](redis/go-redis#3255)) - Added client name support in `HELLO` RESP handshake ([#3294](redis/go-redis#3294)) - **Enabled Search DIALECT 2 by default** ([#3213](redis/go-redis#3213)) - Added read-only option for failover configurations ([#3281](redis/go-redis#3281)) - Added `CountOnly` argument for `FT.Search` to use `LIMIT 0 0` ([#3338](redis/go-redis#3338)) - Added `DB` option support in `NewFailoverClusterClient` ([#3342](redis/go-redis#3342)) - Added `nil` check for the options when creating a client ([#3363](redis/go-redis#3363)) #### 🐛 Bug Fixes - Fixed `PubSub` concurrency safety issues ([#3360](redis/go-redis#3360)) - Fixed panic caused when argument is `nil` ([#3353](redis/go-redis#3353)) - Improved error handling when fetching master node from sentinels ([#3349](redis/go-redis#3349)) - Fixed connection pool timeout issues and increased retries ([#3298](redis/go-redis#3298)) - Fixed context cancellation error leading to connection spikes on Primary instances ([#3190](redis/go-redis#3190)) - Fixed RedisCluster client to consider `MASTERDOWN` a retriable error ([#3164](redis/go-redis#3164)) - Fixed tracing to show complete commands instead of truncated versions ([#3290](redis/go-redis#3290)) - Fixed OpenTelemetry instrumentation to prevent multiple span reporting ([#3168](redis/go-redis#3168)) - Fixed `FT.Search` Limit argument and added `CountOnly` argument for limit 0 0 ([#3338](redis/go-redis#3338)) - Fixed missing command in interface ([#3344](redis/go-redis#3344)) - Fixed slot calculation for `COUNTKEYSINSLOT` command ([#3327](redis/go-redis#3327)) - Updated PubSub implementation with correct context ([#3329](redis/go-redis#3329)) #### 📚 Documentation - Added hash search examples ([#3357](redis/go-redis#3357)) - Fixed documentation comments ([#3351](redis/go-redis#3351)) - Added `CountOnly` search example ([#3345](redis/go-redis#3345)) - Added examples for list commands: `LLEN`, `LPOP`, `LPUSH`, `LRANGE`, `RPOP`, `RPUSH` ([#3234](redis/go-redis#3234)) - Added `SADD` and `SMEMBERS` command examples ([#3242](redis/go-redis#3242)) - Updated `README.md` to use Redis Discord guild ([#3331](redis/go-redis#3331)) - Updated `HExpire` command documentation ([#3355](redis/go-redis#3355)) - Featured OpenTelemetry instrumentation more prominently ([#3316](redis/go-redis#3316)) - Updated `README.md` with additional information ([#310ce55](redis/go-redis@310ce55)) #### ⚡ Performance and Reliability - Bound connection pool background dials to configured dial timeout ([#3089](redis/go-redis#3089)) - Ensured context isn't exhausted via concurrent query ([#3334](redis/go-redis#3334)) #### 🔧 Dependencies and Infrastructure - Updated testing image to Redis 8.0-RC2 ([#3361](redis/go-redis#3361)) - Enabled CI for Redis CE 8.0 ([#3274](redis/go-redis#3274)) - Updated various dependencies: - Bumped golangci/golangci-lint-action from 6.5.0 to 7.0.0 ([#3354](redis/go-redis#3354)) - Bumped rojopolis/spellcheck-github-actions ([#3336](redis/go-redis#3336)) - Bumped golang.org/x/net in example/otel ([#3308](redis/go-redis#3308)) - Migrated golangci-lint configuration to v2 format ([#3354](redis/go-redis#3354)) #### ⚠️ Breaking Changes - **Enabled Search DIALECT 2 by default** ([#3213](redis/go-redis#3213)) - Dropped RedisGears (Triggers and Functions) support ([#3321](redis/go-redis#3321)) - Dropped FT.PROFILE command that was never enabled ([#3323](redis/go-redis#3323)) #### 🔒 Security - Fixed network error handling on SETINFO (CVE-2025-29923) ([#3295](redis/go-redis#3295)) #### 🧪 Testing - Added integration tests for Redis 8 behavior changes in Redis Search ([#3337](redis/go-redis#3337)) - Added vector types INT8 and UINT8 tests ([#3299](redis/go-redis#3299)) - Added test codes for search_commands.go ([#3285](redis/go-redis#3285)) - Fixed example test sorting ([#3292](redis/go-redis#3292)) #### 👥 Contributors We would like to thank all the contributors who made this release possible: [@alexander-menshchikov](https://github.com/alexander-menshchikov), [@EXPEbdodla](https://github.com/EXPEbdodla), [@afti](https://github.com/afti), [@dmaier-redislabs](https://github.com/dmaier-redislabs), [@four_leaf_clover](https://github.com/four_leaf_clover), [@alohaglenn](https://github.com/alohaglenn), [@gh73962](https://github.com/gh73962), [@justinmir](https://github.com/justinmir), [@LINKIWI](https://github.com/LINKIWI), [@liushuangbill](https://github.com/liushuangbill), [@golang88](https://github.com/golang88), [@gnpaone](https://github.com/gnpaone), [@ndyakov](https://github.com/ndyakov), [@nikolaydubina](https://github.com/nikolaydubina), [@oleglacto](https://github.com/oleglacto), [@andy-stark-redis](https://github.com/andy-stark-redis), [@rodneyosodo](https://github.com/rodneyosodo), [@dependabot](https://github.com/dependabot), [@rfyiamcool](https://github.com/rfyiamcool), [@frankxjkuang](https://github.com/frankxjkuang), [@fukua95](https://github.com/fukua95), [@soleymani-milad](https://github.com/soleymani-milad), [@ofekshenawa](https://github.com/ofekshenawa), [@khasanovbi](https://github.com/khasanovbi) </details> --- ### Configuration 📅 **Schedule**: Branch creation - Between 12:00 AM and 03:59 AM ( * 0-3 * * * ) (UTC), Automerge - Between 12:00 AM and 03:59 AM ( * 0-3 * * * ) (UTC). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).  Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/7739 Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org> Co-authored-by: Renovate Bot <forgejo-renovate-action@forgejo.org> Co-committed-by: Renovate Bot <forgejo-renovate-action@forgejo.org>

add readOnly on failover opts

3c1ca57

add failover that if is True it connects to slaves

smilad mentioned this pull request Feb 18, 2025

ReadOnly options on failover #3277

Closed

smilad added 5 commits February 19, 2025 09:54

add test

b981208

add test for slave connect

4b54c6d

fix test

d00e783

fix tests

5c9f92a

skip Flaky

6193148

Merge branch 'master' into patch-1

d0761e7

Merge branch 'master' into patch-1

d6abea0

smilad added 3 commits February 24, 2025 11:42

add more tests on slave

c20d71a

add test

384aa57

Merge branch 'master' into patch-1

9b3d2f5

ndyakov requested changes Feb 26, 2025

View reviewed changes

oryxBuildBinary Outdated Show resolved Hide resolved

smilad and others added 2 commits February 26, 2025 10:35

delete file

d7a8d56

Merge branch 'master' into patch-1

d80c8fc

ndyakov reviewed Feb 26, 2025

View reviewed changes

universal_test.go Outdated Show resolved Hide resolved

Update universal_test.go

cd305aa

enable previously skipped test.

ndyakov added the feature label Feb 26, 2025

ndyakov added 2 commits February 27, 2025 14:17

Merge branch 'master' into patch-1

fc2fba1

Merge branch 'master' into patch-1

b70d16d

smilad requested a review from ndyakov February 27, 2025 18:59

rm skip from sentinels

96d8d9e

smilad and others added 2 commits February 27, 2025 21:05

rm tmp files

667031c

Merge branch 'master' into patch-1

d0ab0eb

ndyakov reviewed Feb 28, 2025

View reviewed changes

universal_test.go Outdated Show resolved Hide resolved

Update universal_test.go

f011046

don't run sentinel test in RE

Merge branch 'master' into patch-1

081b71f

ndyakov added 2 commits March 4, 2025 16:18

Merge branch 'master' into patch-1

50b6d55

Merge branch 'master' into patch-1

f55a990

ndyakov reviewed Mar 6, 2025

View reviewed changes

universal_test.go Outdated Show resolved Hide resolved

Update universal_test.go

e77cc8c

ndyakov self-requested a review March 6, 2025 14:52

ndyakov approved these changes Mar 6, 2025

View reviewed changes

ndyakov merged commit 8fadbef into redis:master Mar 6, 2025
16 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

add readOnly on failover opts #3281

add readOnly on failover opts #3281

Uh oh!

smilad commented Feb 18, 2025

Uh oh!

ndyakov commented Feb 19, 2025

Uh oh!

smilad commented Feb 19, 2025

Uh oh!

ndyakov commented Feb 20, 2025

Uh oh!

smilad commented Feb 22, 2025 •

edited

Loading

Uh oh!

ndyakov commented Feb 24, 2025

Uh oh!

ndyakov commented Feb 26, 2025

Uh oh!

Uh oh!

ndyakov left a comment

Uh oh!

Uh oh!

ndyakov commented Feb 26, 2025

Uh oh!

smilad commented Feb 27, 2025 •

edited

Loading

Uh oh!

Uh oh!

smilad commented Mar 1, 2025

Uh oh!

ndyakov commented Mar 4, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

add readOnly on failover opts #3281

add readOnly on failover opts #3281

Uh oh!

Conversation

smilad commented Feb 18, 2025

Uh oh!

ndyakov commented Feb 19, 2025

Uh oh!

smilad commented Feb 19, 2025

Uh oh!

ndyakov commented Feb 20, 2025

Uh oh!

smilad commented Feb 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ndyakov commented Feb 24, 2025

Uh oh!

ndyakov commented Feb 26, 2025

Uh oh!

Uh oh!

ndyakov left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ndyakov commented Feb 26, 2025

Uh oh!

smilad commented Feb 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

smilad commented Mar 1, 2025

Uh oh!

ndyakov commented Mar 4, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

smilad commented Feb 22, 2025 •

edited

Loading

smilad commented Feb 27, 2025 •

edited

Loading