Skip to content

fix(tests): enable testing with Redis CE 8.0-M4 in CI #3247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jan 31, 2025
Merged

fix(tests): enable testing with Redis CE 8.0-M4 in CI #3247

merged 7 commits into from
Jan 31, 2025

Conversation

ndyakov
Copy link
Member

@ndyakov ndyakov commented Jan 23, 2025 •
edited
Loading

  • drop older go versions from the matrix
  • add multiple Redis versions to the matrix
  • enable osscluster tests with Redis CE
  • fix FT.SEARCH test to address the new default scorer
  • add env variable with the major redis version, to skip tests if needed

@ndyakov ndyakov added this to the testing-improvements milestone Jan 23, 2025
@ndyakov ndyakov force-pushed the ndyakov/improve-testing-setup branch 3 times, most recently from 81407a2 to 389a45f Compare January 28, 2025 09:55
@ndyakov ndyakov requested a review from ofekshenawa January 29, 2025 08:57
@ndyakov ndyakov changed the title [DRAFT] Improve testing setup fix(tests): enable testing with Redis CE 8.0-M4 in CI Jan 29, 2025
@ndyakov ndyakov marked this pull request as ready for review January 29, 2025 11:05
@ndyakov ndyakov requested a review from vladvildanov January 29, 2025 11:05
@ndyakov ndyakov mentioned this pull request Jan 29, 2025
Closed
@ndyakov
introduce github workflow for ci similar to the one in redis-py
d5d0f27 
use prerelease for 8.0-M4
@ndyakov
Enable osscluster tests in CI
a2c85f9
@ndyakov
Add redis major version env
243b446 
Enable filtering test per redis major version
Fix test for FT.SEARCH WITHSCORE, the default scorer
has changed.

fix Makefile syntax

remove filter from github action

fix makefile

use the container name in Makefile
@ndyakov
remove 1.20 from doctests
8c213cf
@ndyakov
self review, cleanup, add comments
c2b8c63
@ndyakov ndyakov force-pushed the ndyakov/improve-testing-setup branch from a2008e0 to c2b8c63 Compare January 29, 2025 13:11
@ndyakov ndyakov mentioned this pull request Jan 29, 2025
Closed
@vladvildanov vladvildanov merged commit 1139bc3 into master Jan 31, 2025
15 checks passed
@ndyakov ndyakov deleted the ndyakov/improve-testing-setup branch February 7, 2025 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladvildanov vladvildanov vladvildanov approved these changes

@ofekshenawa ofekshenawa Awaiting requested review from ofekshenawa

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
testing-improvements
Development

Successfully merging this pull request may close these issues.
2 participants
@ndyakov @vladvildanov