Add RunLoad to script #2604
Open
Add RunLoad to script #2604
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add new `RunLoad` method to Script. It tries to run the script using `EvalSha`, if that fails, it loads the script using SCRIPTLOAD and then tries again. This is what the redis manual recommends libraries to do: From https://redis.io/docs/manual/programmability/eval-intro/ > In this case, the application should first load it with SCRIPT LOAD > and then call EVALSHA once more to run the cached script by its SHA1 > sum. Most of Redis' clients already provide utility APIs for doing > that automatically. Please consult your client's documentation > regarding the specific details
|
Hey @simao, Before we merge, could you write unit tests? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new
RunLoadmethod to Script. It tries to run the script usingEvalSha, if that fails, it loads the script using SCRIPTLOAD and then tries again.This is what the redis manual recommends libraries to do:
From https://redis.io/docs/manual/programmability/eval-intro/
Please let me know if you think this should be merged, I will write some tests.