feat: add lock for hooks.dial #2460
Open
+35
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: monkey92t <golang@88.com>
monkey92t
force-pushed
the
dialHookThreadSafe
branch
from
f0139ae to
24fa725
Compare
|
I've tried to review you this, but the existing code looks confusing enough and locking does not make it better :( I will try to get back to this later and make API cleaner and more understandable... |
Yes...Indeed, we introduced more complex code to solve a problem, and in my view, DialHook and MinIdleConns are conflicting. |
|
Any updates? |
|
ping |
|
@vmihailenco any updates on this? :) |
|
ping |
|
@monkey92t would you like to revisit this after #3320 ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #2453
We added a lock to
DialHook, butProcessHook,ProcessPipelineHookare still not thread-safe.If the
Options.MinIdleConnsparameter is set, go-redis will create a network connection asynchronously, and there may be a data race (hooks.dial) with theAddHook()API, and even a part of the network connection is created before theAddHookoperation.We only need to pay for the overhead of the read lock for the DialHook.