Commit 65736aa
electron upgraded from 33.* to 36.* (#4740)
* Update Electron from 33.2.0 to 36.4.0 and related dependencies
- Update electron from EOL version 33.2.0 to supported 36.4.0
- Update electron-builder from 24.13.3 to 26.0.12
- Update electron-updater from 6.3.9 to 6.6.2
- Add node-abi 4.12.0 for better Electron version support
- Update yarn.lock files with new dependency versions
🤖 Generated with [Claude Code](https://claude.ai/code)
Co-Authored-By: Claude <noreply@anthropic.com>
* rolled back local changes
* rolled back local changes
* Update Node.js version from 22.11.0 to 22.12.0 for node-abi compatibility
The node-abi@4.12.0 package requires Node.js >=22.12.0 but CI was using 22.11.0.
This update ensures compatibility with the upgraded Electron dependencies.
🤖 Generated with [Claude Code](https://claude.ai/code)
Co-Authored-By: Claude <noreply@anthropic.com>
* Testing slightly different config to fix the resolutions after install
* Fix electron-builder 26.0.12 configuration compatibility
- Update Linux desktop configuration to use desktop.entry structure
- Change Mac notarize from object to boolean (temporarily disabled)
- Replace Windows publisherName with legalTrademarks
- Remove electron-builder install-app-deps from postinstall script
These changes address breaking changes in electron-builder 26.0.12.
🤖 Generated with [Claude Code](https://claude.ai/code)
Co-Authored-By: Claude <noreply@anthropic.com>
* Restore Mac notarization and disable native module rebuilding
- Restore Mac notarization with teamId configuration (good security practice)
- Add npmRebuild: false, nodeGypRebuild: false, buildDependenciesFromSource: false
to disable native module rebuilding which fails due to ABI compatibility issues
- This allows electron-builder to proceed without trying to rebuild native modules
like keytar and sqlite3 that cause ABI detection errors with Electron 36
🤖 Generated with [Claude Code](https://claude.ai/code)
Co-Authored-By: Claude <noreply@anthropic.com>
* Update Mac notarize configuration to boolean for electron-builder 26.0.12
In electron-builder 26.0.12, notarize must be a boolean value. The actual
notarization configuration (teamId, etc.) is now handled via environment
variables such as APPLE_TEAM_ID=UUK47G4BAZ instead of in the config file.
🤖 Generated with [Claude Code](https://claude.ai/code)
Co-Authored-By: Claude <noreply@anthropic.com>
* Reverting unneeded changes
* Reverting unneeded changes
* reverting yarn.lock in the api folder for testing
---------
Co-authored-by: Claude <noreply@anthropic.com>1 parent 9508198 commit 65736aa
File tree
4 files changed
+265
-216
lines changed- .github/actions/install-all-build-libs
4 files changed
+265
-216
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
33 | 33 | | |
34 | 34 | | |
35 | 35 | | |
36 | | - | |
| 36 | + | |
37 | 37 | | |
38 | 38 | | |
39 | 39 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
5 | 5 | | |
6 | 6 | | |
7 | 7 | | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
8 | 11 | | |
9 | 12 | | |
10 | 13 | | |
| |||
24 | 27 | | |
25 | 28 | | |
26 | 29 | | |
27 | | - | |
28 | | - | |
29 | | - | |
| 30 | + | |
30 | 31 | | |
31 | 32 | | |
32 | 33 | | |
| |||
86 | 87 | | |
87 | 88 | | |
88 | 89 | | |
89 | | - | |
| 90 | + | |
90 | 91 | | |
91 | 92 | | |
92 | 93 | | |
| |||
117 | 118 | | |
118 | 119 | | |
119 | 120 | | |
120 | | - | |
121 | | - | |
122 | | - | |
| 121 | + | |
| 122 | + | |
| 123 | + | |
| 124 | + | |
| 125 | + | |
123 | 126 | | |
124 | 127 | | |
125 | 128 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
43 | 43 | | |
44 | 44 | | |
45 | 45 | | |
46 | | - | |
| 46 | + | |
47 | 47 | | |
48 | 48 | | |
49 | 49 | | |
| |||
158 | 158 | | |
159 | 159 | | |
160 | 160 | | |
161 | | - | |
162 | | - | |
| 161 | + | |
| 162 | + | |
163 | 163 | | |
164 | 164 | | |
165 | 165 | | |
| |||
254 | 254 | | |
255 | 255 | | |
256 | 256 | | |
257 | | - | |
| 257 | + | |
258 | 258 | | |
259 | 259 | | |
260 | 260 | | |
| |||
272 | 272 | | |
273 | 273 | | |
274 | 274 | | |
275 | | - | |
| 275 | + | |
276 | 276 | | |
277 | 277 | | |
278 | 278 | | |
| |||
0 commit comments