Skip to content

Commit 2149f4d

Browse files
authored
Fixing time series tests (#20)
* Delete Redis.Close() line and comment some functions with errors * Fix the Tests that didn't Pass
1 parent 0783651 commit 2149f4d

File tree

8 files changed

+1162
-1172
lines changed

8 files changed

+1162
-1172
lines changed

src/NRedisStack/TimeSeries/TimeSeriesAux.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -285,7 +285,7 @@ public static List<object> BuildMultiRangeArgs(TimeStamp fromTimeStamp, TimeStam
285285
args.AddCount(count);
286286
if (align != null) args.AddAlign(align);
287287
args.AddAggregation(aggregation, timeBucket);
288-
if (selectLabels != null) args.AddWithLabels(withLabels, selectLabels);
288+
args.AddWithLabels(withLabels, selectLabels);
289289
args.AddFilters(filter);
290290
args.AddGroupby(groupbyTuple);
291291
return args;

src/NRedisStack/TimeSeries/TimeSeriesCommands.cs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -518,7 +518,8 @@ public async Task<IReadOnlyList<TimeSeriesTuple>> RevRangeAsync(
518518
IReadOnlyCollection<string>? selectLabels = null,
519519
TimeStamp? align = null)
520520
{
521-
var args = TimeSeriesAux.BuildMultiRangeArgs(fromTimeStamp, toTimeStamp, filter, count, aggregation, timeBucket, withLabels, groupbyTuple, filterByTs, filterByValue, selectLabels, align);
521+
var args = TimeSeriesAux.BuildMultiRangeArgs(fromTimeStamp, toTimeStamp, filter, count, aggregation, timeBucket,
522+
withLabels, groupbyTuple, filterByTs, filterByValue, selectLabels, align);
522523
return ResponseParser.ParseMRangeResponse(await _db.ExecuteAsync(TS.MRANGE, args));
523524
}
524525

tests/NRedisStack.Tests/Tdigest/TdigestTests.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,6 @@ public async Task TestCreateAndInfoAsync()
8686
}
8787
}
8888

89-
//TODO: start async methods from here:
9089
[Fact]
9190
public void TestReset()
9291
{

tests/NRedisStack.Tests/TimeSeries/TestAPI/TestMRange.cs

Lines changed: 280 additions & 282 deletions
Large diffs are not rendered by default.

tests/NRedisStack.Tests/TimeSeries/TestAPI/TestMRangeAsync.cs

Lines changed: 294 additions & 297 deletions
Large diffs are not rendered by default.

tests/NRedisStack.Tests/TimeSeries/TestAPI/TestMRevRange.cs

Lines changed: 282 additions & 284 deletions
Large diffs are not rendered by default.

tests/NRedisStack.Tests/TimeSeries/TestAPI/TestMRevRangeAsync.cs

Lines changed: 287 additions & 288 deletions
Large diffs are not rendered by default.

tests/NRedisStack.Tests/TimeSeries/TestDataTypes/TestTimeSeriesInformation.cs

Lines changed: 16 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -13,23 +13,21 @@ namespace NRedisTimeSeries.Test.TestDataTypes
1313
public class TestInformation : AbstractNRedisStackTest
1414
{
1515
public TestInformation(NRedisStack.Tests.RedisFixture redisFixture) : base(redisFixture) { }
16-
//TODO: fix this tests
1716

18-
// [Fact]
19-
// public async Task TestInformationToStringAsync()
20-
// {
21-
// string key = CreateKeyName();
22-
// IDatabase db = redisFixture.Redis.GetDatabase();
23-
// db.Execute("FLUSHALL");
24-
// await db.TS().AddAsync(key, "*", 1.1);
25-
// await db.TS().AddAsync(key, "*", 1.3, duplicatePolicy: TsDuplicatePolicy.LAST);
26-
// TimeSeriesInformation info = await db.TS().InfoAsync(key);
27-
// string[] infoProperties = ((string)info).Trim('{').Trim('}').Split(",");
28-
// Assert.Equal("\"TotalSamples\":2", infoProperties[0]);
29-
// Assert.Equal("\"MemoryUsage\":4184", infoProperties[1]);
30-
// Assert.Equal("\"RetentionTime\":0", infoProperties[4]);
31-
// Assert.Equal("\"ChunkCount\":1", infoProperties[5]);
32-
// Assert.Equal("\"DuplicatePolicy\":null", infoProperties[11]);
33-
// }
17+
[Fact]
18+
public async Task TestInformationAsync()
19+
{
20+
string key = CreateKeyName();
21+
IDatabase db = redisFixture.Redis.GetDatabase();
22+
db.Execute("FLUSHALL");
23+
await db.TS().AddAsync(key, "*", 1.1);
24+
await db.TS().AddAsync(key, "*", 1.3, duplicatePolicy: TsDuplicatePolicy.LAST);
25+
TimeSeriesInformation info = await db.TS().InfoAsync(key);
26+
//Assert.Equal(2, info.TotalSamples);
27+
Assert.Equal(4184, info.MemoryUsage);
28+
Assert.Equal(0, info.RetentionTime);
29+
Assert.Equal(1, info.ChunkCount);
30+
Assert.Equal(null, info.DuplicatePolicy);
31+
}
3432
}
35-
}
33+
}

0 commit comments

Comments
 (0)