Skip to content

Conversation

JoanFM
Copy link

@JoanFM JoanFM commented Sep 10, 2025

No description provided.

@hdoordt
Copy link
Contributor

hdoordt commented Sep 10, 2025

@JoanFM I opened #455 just now, which supports loading data from standard pyproject.toml files, falling back to the poetry structure. In case of RediSearch, this is preferable, as that project uses uv to manage the python test packages

@JoanFM
Copy link
Author

JoanFM commented Sep 10, 2025

good for me @hdoordt . I actually wonder what this is used for, what is the supposed to override, I just want the CI on RediSearch to pass, and seems like whichever should work

@hdoordt
Copy link
Contributor

hdoordt commented Sep 10, 2025

I'm not too well-versed on the internals of this repo, but I'd say it's best to prefer assigning the values if possible.

@JoanFM
Copy link
Author

JoanFM commented Sep 10, 2025

I'm not too well-versed on the internals of this repo, but I'd say it's best to prefer assigning the values if possible.

Me neither, but I actually think that this project should be the RedisBenchAdmin, not sure why it has to take the path from the local running folder. (I believe this is the underlying problem), Not sure what is the purpose of the info extracted and what it intends to print. @filipecosta90 @paulorsousa ?

@JoanFM
Copy link
Author

JoanFM commented Sep 10, 2025

Actually, maybe we need just to remove the pyproject access, not sure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants