Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve file-copy performance in docker using rsync #76

Open
s1061123 opened this issue Feb 21, 2017 · 4 comments
Open

improve file-copy performance in docker using rsync #76

s1061123 opened this issue Feb 21, 2017 · 4 comments
Assignees
Milestone

Comments

@s1061123
Copy link
Collaborator

s1061123 commented Feb 21, 2017

At that time, toad with docker uses 'copy:' module instead of 'synchronize:' module because docker connection in ansible does not support rsync that 'synchronize:' module uses. But performance point of view, rsync is better performance as following document:
http://docs.ansible.com/ansible/copy_module.html#notes

Currently ansible-devel supprort rsync with docker at following PR.
ansible/ansible#18145

After merging (i.e. official release), we should catch up with the changes.

@leifmadsen leifmadsen added this to the 17.03 milestone Mar 15, 2017
@leifmadsen
Copy link
Contributor

@s1061123 I believe this is now available in the 2.2.1.0 release, so can you take a stab at working on this issue?

@s1061123
Copy link
Collaborator Author

I also checked tag "v2.2.2.0-0.2.rc2" and it does not have this fix yet...
https://github.com/ansible/ansible/blob/v2.2.2.0-0.2.rc2/lib/ansible/plugins/action/synchronize.py

So we may need to move it future release...

@s1061123 s1061123 modified the milestones: 17.03, 17.04 Mar 15, 2017
@leifmadsen
Copy link
Contributor

Ah ok, for some reason I thought I saw the commit in 2.2.1.0 since it looked like it was merged in December 2016?

@leifmadsen
Copy link
Contributor

I guess we'll be waiting for 2.3.0 for this change, so we'll just defer to a future milestone.

@leifmadsen leifmadsen modified the milestones: Future, 17.04 Mar 15, 2017
@leifmadsen leifmadsen added blocked and removed ready labels Mar 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants