Skip to content

Conversation

@rgrunber
Copy link
Member

@rgrunber rgrunber commented Jan 31, 2024

- Bump graalvm/setup-graalvm to 1.1.6 and adapt to new parameters

Signed-off-by: Roland Grunberg <rgrunber@redhat.com>
@rgrunber rgrunber requested a review from datho7561 January 31, 2024 19:33
Copy link
Contributor

@datho7561 datho7561 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes seem good. I have no way of testing the .vsix, it would be nice to get confirmation it works before releasing.

@fbricon
Copy link
Collaborator

fbricon commented Jan 31, 2024

I should be able to test it tomorrow on a MacBook Air M1

@rgrunber
Copy link
Member Author

rgrunber commented Feb 3, 2024

User confirmed the aarch64 MacOS vsix worked for them, so merging.

@rgrunber rgrunber merged commit fb0d934 into redhat-developer:main Feb 3, 2024
@rgrunber rgrunber deleted the mac-arm branch February 3, 2024 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Mac ARM / AS

3 participants