Replace obsolete AdoptOpenJDK link with Adoptium #707
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In 2021, AdoptOpenJDK has become Adoptium. [1] The old site does point to the new site but that requires several additional clicks to get there. Besides, the old download site is no longer being updated, and fails to mention JDK 17. [2] [1]: https://blog.adoptopenjdk.net/2021/08/goodbye-adoptopenjdk-hello-adoptium/ [2]: https://adoptopenjdk.net/releases.html
rgrunber
approved these changes
May 9, 2022
Member
rgrunber
left a comment
rgrunber
left a comment
There was a problem hiding this comment.
Good catch. The fact that latest is still OpenJDK 16 there is a hint we should have changed.
Same could probably be done for JDK 11 link at https://github.com/redhat-developer/vscode-microprofile/blob/master/CONTRIBUTING.md#installation-prerequisites .
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 2021, AdoptOpenJDK has become Adoptium.
The old site does point to the new site but that requires several additional clicks to get there. Besides, the old download site is no longer being updated, and fails to mention JDK 17.
See also #270.