Skip to content

Use curl instead of wget to be consistent with usage #639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 27, 2022
Merged

Use curl instead of wget to be consistent with usage #639

merged 1 commit into from
Jan 27, 2022

Conversation

@rgrunber
Copy link
Member

@rgrunber rgrunber commented Jan 25, 2022 •
edited
Loading

  • Also on certain machines, wget (without --inet4-only) can fail with
    default options

Signed-off-by: Roland Grunberg rgrunber@redhat.com

Sample of the possible failure :

12:38:21  + wget https://download.jboss.org/jbosstools/vscode/snapshots/lemminx-binary/0.18.3-482/lemminx-linux.sha256 -O ./server/lemminx-linux.sha256
12:38:21  --2022-01-25 12:38:20--  https://download.jboss.org/jbosstools/vscode/snapshots/lemminx-binary/0.18.3-482/lemminx-linux.sha256
12:38:21  Resolving download.jboss.org (download.jboss.org)... ${some_ipv6_addr}, ${some_ipv6_addr}, ${some_ipv4_addr}, ...
12:38:24  Connecting to download.jboss.org (download.jboss.org)|${some_ipv6_addr}|:443... failed: No route to host.
12:38:27  Connecting to download.jboss.org (download.jboss.org)|${some_ipv6_addr}|:443... failed: No route to host.
12:38:27  Connecting to download.jboss.org (download.jboss.org)|${some_ipv4_addr}|:443... connected.
12:38:27  HTTP request sent, awaiting response... 404 Not Found
12:38:27  2022-01-25 12:38:26 ERROR 404: Not Found.

@rgrunber
Use curl instead of wget to be consistent with usage
71685d0 
- Also on certain machines, wget (without --inet4-only) can fail with
  default options

Signed-off-by: Roland Grunberg <rgrunber@redhat.com>
@rgrunber rgrunber requested a review from fbricon January 25, 2022 19:40
AlexXuChen
AlexXuChen approved these changes Jan 27, 2022
View reviewed changes
Copy link
Contributor

@AlexXuChen AlexXuChen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rgrunber rgrunber added the build label Jan 27, 2022
@rgrunber rgrunber added this to the 0.18.3 milestone Jan 27, 2022
@rgrunber rgrunber merged commit 9c9d2bf into redhat-developer:master Jan 27, 2022
@rgrunber rgrunber deleted the use-curl branch January 27, 2022 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fbricon fbricon Awaiting requested review from fbricon

1 more reviewer

@AlexXuChen AlexXuChen AlexXuChen approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

build

Projects

None yet

Milestone

0.18.3

Development

Successfully merging this pull request may close these issues.

2 participants

@rgrunber @AlexXuChen