autoClosingBrackets are forced off if autoCloseTags is enabled #62
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NikolasKomonen
force-pushed
the
disableAutoCloseBrackets
branch
from
a04213f to
57581be
Compare
fbricon
reviewed
Oct 16, 2018
src/extension.ts
Outdated
| function getSettings(): JSON { | ||
| let configXML = workspace.getConfiguration(); | ||
|
|
||
| let autoCloseTags = configXML.get("xml.completion.autoCloseTags"); |
Collaborator
There was a problem hiding this comment.
this should only happen on configuration change on the client side.
there's no need to send that config to the server
fbricon
reviewed
Oct 16, 2018
src/extension.ts
Outdated
|
|
||
| let autoCloseTags = configXML.get("xml.completion.autoCloseTags"); | ||
| let autoClosingBrackets = configXML.get("[xml]")["editor.autoClosingBrackets"]; | ||
| if (autoCloseTags && autoClosingBrackets != "never") { |
Collaborator
There was a problem hiding this comment.
you need to ask permission for changing the value. Not do it 1st and ask for forgiveness
fbricon
reviewed
Oct 16, 2018
NikolasKomonen
force-pushed
the
disableAutoCloseBrackets
branch
2 times, most recently
from
b392503 to
6486e19
Compare
fbricon
reviewed
Oct 16, 2018
src/extension.ts
Outdated
| (error) => console.log(error) | ||
| ); | ||
| } | ||
| else { |
Collaborator
There was a problem hiding this comment.
be careful, this is the case when user presses escape. You don't want to do anything if action gets cancelled on purpose
Collaborator
Author
There was a problem hiding this comment.
good catch, ill fix
NikolasKomonen
force-pushed
the
disableAutoCloseBrackets
branch
from
6486e19 to
da64432
Compare
fbricon
requested changes
Oct 16, 2018
src/extension.ts
Outdated
| let autoCloseTags = configXML.get("xml.completion.autoCloseTags"); | ||
| let autoClosingBrackets = configXML.get("[xml]")["editor.autoClosingBrackets"]; | ||
| if (autoCloseTags && autoClosingBrackets != "never") { | ||
| window.showInformationMessage( |
NikolasKomonen
force-pushed
the
disableAutoCloseBrackets
branch
from
da64432 to
fa23a10
Compare
fbricon
reviewed
Oct 16, 2018
NikolasKomonen
force-pushed
the
disableAutoCloseBrackets
branch
2 times, most recently
from
6e221ab to
ba94c4f
Compare
Collaborator
Author
|
@fbricon Updated, I didnt add the preference for the warning though. It will just remember for the servers lifecycle and not ask again. |
NikolasKomonen
force-pushed
the
disableAutoCloseBrackets
branch
from
ba94c4f to
4e699ff
Compare
fbricon
reviewed
Oct 19, 2018
src/extension.ts
Outdated
| let configXML = workspace.getConfiguration(); | ||
| let autoCloseTags = configXML.get("xml.completion.autoCloseTags"); | ||
| let autoClosingBrackets = configXML.get("[xml]"); | ||
| console.log(autoClosingBrackets); |
fbricon
reviewed
Oct 19, 2018
src/extension.ts
Outdated
| let autoCloseTags = configXML.get("xml.completion.autoCloseTags"); | ||
| let autoClosingBrackets = configXML.get("[xml]"); | ||
| console.log(autoClosingBrackets); | ||
| autoClosingBrackets = autoClosingBrackets["editor.autoClosingBrackets"]; |
Collaborator
There was a problem hiding this comment.
please use a different variable name. this is too confusing
fbricon
reviewed
Oct 19, 2018
Collaborator
|
Few minor changes left to do but it looks pretty good now. |
Fixes redhat-developer#38 Signed-off-by: Nikolas Komonen <nikolaskomonen@gmail.com>
NikolasKomonen
force-pushed
the
disableAutoCloseBrackets
branch
from
4e699ff to
40859e1
Compare
Collaborator
Author
|
@fbricon Updated |
fbricon
approved these changes
Oct 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.