Skip to content

Fix excessive autoclose calls #153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 6, 2019
Merged

Fix excessive autoclose calls #153

merged 1 commit into from
Jun 6, 2019

Conversation

@fbricon
Copy link
Collaborator

@fbricon fbricon commented Jun 6, 2019

Autoclose requests were sent on all keystrokes, instead of limiting them to the trigger characters.
The test condition was incorrectly written.

@fbricon
Fix excessive autoclose calls
24fc156 
Signed-off-by: Fred Bricon <fbricon@gmail.com>
@fbricon fbricon requested a review from NikolasKomonen June 6, 2019 06:14
@fbricon fbricon added bug Something isn't working completion labels Jun 6, 2019
@fbricon fbricon added this to the v0.7.0 milestone Jun 6, 2019
@fbricon fbricon self-assigned this Jun 6, 2019
@NikolasKomonen NikolasKomonen merged commit e3b0081 into redhat-developer:master Jun 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NikolasKomonen NikolasKomonen NikolasKomonen approved these changes

Assignees

@fbricon fbricon

Labels

bug Something isn't working completion

Projects

None yet

Milestone

v0.7.0

Development

Successfully merging this pull request may close these issues.

2 participants

@fbricon @NikolasKomonen