JRE support #136
Closed
JRE support #136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only JDK is supported. Generally users who don't develop with Java, have an installed JRE not a JDK. I think javac is used here because it was a copy/paste from jdt ls code which requires JDK. This very simple PR checks if java exists and javac. But it requires to declare the JRE with java.home. It should be improved to find JRE like we have that with JDK.
Collaborator
|
We need to introduce a vscode-xml specific java.home variable, maybe |
fbricon
requested changes
May 21, 2019
| } | ||
| if(!pathExists.sync(path.resolve(javaHome, 'bin', JAVAC_FILENAME))){ | ||
| if(!pathExists.sync(path.resolve(javaHome, 'bin', JAVA_FILENAME))){ | ||
| openJDKDownload(reject, source+ ' does not point to a JDK.'); |
Collaborator
There was a problem hiding this comment.
does not point to a Java runtime
fbricon
requested changes
Jun 3, 2019
Collaborator
fbricon
left a comment
fbricon
left a comment
There was a problem hiding this comment.
Also need to add {allowJre: true} to findJavaHome call, L63
Merged
Collaborator
|
Closing as superseded by #152 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only JDK is supported. Generally users who don't develop with Java, have an installed JRE not a JDK. I think javac is used here because it was a copy/paste from jdt ls code which requires JDK.
This very simple PR checks if java exists and not javac. But it requires to declare the JRE with java.home. It should be improved to find JRE like we have that with JDK.