Error when booting extension on Mac Silicon

[robertmoura]

Thanks for working on this extension! Really love using it for formatting XML files.

I recently upgraded my Mac and this extension used to work but is failing on start up now. I think it may have something to do with the M1 chip? Any idea what could be causing this issue? Here's what I'm getting in the XML Support output:

[Error - 11:50:19] XML Support client: couldn't create connection to server.
Error: spawn Unknown system error -86
    at ChildProcess.spawn (node:internal/child_process:413:11)
    at Object.spawn (node:child_process:795:9)
    at transports (/Users/___/.vscode/extensions/redhat.vscode-xml-0.26.1-darwin-arm64/node_modules/vscode-languageclient/lib/node/main.js:424:46)
    at w.connection [as createConnection] (/Users/___/.vscode/extensions/redhat.vscode-xml-0.26.1-darwin-arm64/node_modules/vscode-languageclient/lib/common/client.js:1030:15)
    at w.start (/Users/___/.vscode/extensions/redhat.vscode-xml-0.26.1-darwin-arm64/node_modules/vscode-languageclient/lib/common/client.js:612:19)

[angelozerr]

@fbricon have you the same problem ?

[Estreuselito]

I second that, I have a the exact same issue as described by @robertmoura. Thank you for looking into this! I highly appreciate your effort!

[angelozerr]

@fbricon @datho7561 @rgrunber have you some idea about the problem?

[fbricon]

Tried on a MacBok Air M1 without any problem.

spawn Unknown system error -86 might suggest a corrupt file.

Can you try the latest vscode-xml pre-release?

[Estreuselito]

Hm, sadly that did not work. I am running a MacBook Pro M3. Here are some screenshots after switching to pre-release:

After clicking on yes:

I would appreciate any help :)

[fbricon]

can you check in the Mac security settings if the binary was blocked from running?

[rgrunber]

For darwin-arm64, the binary should be lemminx-osx-aarch_64, and not lemminx-osx-x86_64

$ ls
redhat.vscode-xml-0.26.2024022308@darwin-arm64.vsix
$ unzip -Z1 redhat.vscode-xml-0.26.2024022308@darwin-arm64.vsix | grep server
extension/server/lemminx-osx-aarch_64
extension/server/lemminx-osx-aarch_64.sha256
extension/server/org.eclipse.lemminx-uber.jar

How was your vscode-xml installed ? Did you download it from somewhere, or did you install it through the VS Code Marketplace ?

[robertmoura]

I got the same issue as @Estreuselito when installing the pre-release.

can you check in the Mac security settings if the binary was blocked from running?

Hmm, not exactly sure how to check that but in the Privacy & Security section of the System Settings I can't see anything out of the ordinary. Was there something specific that you were looking for?

How was your vscode-xml installed ?

Just via the VS Code Marketplace. Nothing out of the ordinary that I know of.

[rgrunber]

vscode-xml/src/server/binary/binaryServerStarter.ts

Lines 216 to 218 in 4549a37

	case 'darwin':
	// FIXME: once we support Apple ARM, incorporate the architecture into this string
	return 'lemminx-osx-x86_64';

😐 thanks @datho7561 for reminding about this. I'll propose a fix.

As a workaround, could anyone with the issue try :

1. Going into /Users/.../vscode/extensions/redhat.vscode-xml-0.26.20204022308-darwin-arm64/server/.
2. Confirm there is a file there named lemminx-osx-aarch_64, and rename it to lemminx-osx-x86_64.
3. Start VS Code and see whether the XML functionality works through the binary. You will likely have to click "Yes" to trust the binary on the prompt, when it comes up.

[robertmoura]

@rgrunber Thanks for looking into this issue! When going to that folder I already had that file. On the pre-release version I had both files in that folder so I'm not sure what to do in this case. Did you have any ideas?

Pre release version:

[rgrunber]

The first screenshot makes sense. Looks like it's of the 0.26.1 release, which did package the x86_64 LemMinX binary for macos-arm64 (relying on Rosetta layer to work).

As for the pre-release, I think I found yet another (similar) issue :

vscode-xml/package.json

Lines 27 to 31 in 4549a37

	"binaryServerDownloadUrl": {
	"linux": "https://github.com/redhat-developer/vscode-xml/releases/download/latest/lemminx-linux.zip",
	"osx-x86_64": "https://github.com/redhat-developer/vscode-xml/releases/download/latest/lemminx-osx-x86_64.zip",
	"win32": "https://github.com/redhat-developer/vscode-xml/releases/download/latest/lemminx-win32.zip"
	},

In the event a binary can't be found locally, we download based on that logic. My guess is if the "aarch_64" (macos-arm64) binary failed to be located (because it was wrongly looking for the x76_64 one), the extension tried to download a pre-release version.. of the wrong version (the "latest" folder only applies to pre-releases).

I'll need to update this part of the build. @robertmoura , if you're able to do so the following would help :

1. call file lemminx-osx-aarch_64 lemminx-osx-x86_64 and confirrm the output looks something like :

$ file lemminx-osx-aarch_64 lemminx-osx-x86_64
lemminx-osx-aarch_64: Mach-O 64-bit arm64 executable, flags:<NOUNDEFS|DYLDLINK|TWOLEVEL|PIE>
lemminx-osx-x86_64:   Mach-O 64-bit x86_64 executable, flags:<NOUNDEFS|DYLDLINK|TWOLEVEL|PIE>

Specifically, the aarch64 one should say something about arm64 and the x86_64 one should say something about x86_64.

2. Just replace the aarch64 file with the x86_64 file

$ mv lemminx-osx-aarch_64 lemminx-osx-x86_64

This should just allow the extension to use the wrong file path, which now has the correct binary.

3. Now start VS Code and see how the XML functionality works. You'll likely have a prompt asking to trust the binary.

Hopefully that works and confirms all the changes we need to make to fix things.

[robertmoura]

I've run that and got the following which matches what you've said.

lemminx-osx-aarch_64: Mach-O 64-bit executable arm64
lemminx-osx-x86_64:   Mach-O 64-bit executable x86_64

After running step 2 and restarting VSCode the extension seems to work as intended! I believe you may have hit this one on the head! Thanks heaps @rgrunber for being on top of this one! Really appreciate it 😊