XML catalog support apparently not working

[ralfhandl]

I need to validate XML files against their XML schemas, and injecting xsi:schemaLocations into those files is not possible/feasible.

XML catalogs should solve that, yet I can't get that to work.

What I tried in USER SETTINGS:

    "xml.catalogs": [
        "O:\\git\\odata-csdl-schemas\\catalog.xml"
    ]

The file O:\git\odata-csdl-schemas\catalog.xml contains

<?xml version="1.0"?>
<catalog xmlns="urn:oasis:names:tc:entity:xmlns:xml:catalog">
  <uri name="urn:oasis:names:tc:entity:xmlns:xml:catalog" uri="jar:file:/C:/eclipse-Photon/plugins/org.eclipse.wst.standard.schemas_1.0.800.v201711201732.jar!/xsd/xmlcatalog11.xsd" />
  <uri name="http://docs.oasis-open.org/odata/ns/edmx" uri="http://localhost/odata-schemas/edmx.xsd" />
  <uri name="http://docs.oasis-open.org/odata/ns/edm" uri="http://localhost/odata-schemas/edm.xsd" />
</catalog>

The first entry is copied from Eclipse's system_catalog.xml and should help validate the catalog.xml - it doesn't.

The second and third entries map the XML namespaces I'm actually interested in to local copies of the corresponding XML Schema files. The files are accessible via my local web server at the URIs listed in the file. Neither validation nor code completion are working as expected.

Removing the first entry with the jar: URL doesn't make the other two work.

What am I doing wrong?

Thanks in advance
Ralf

[fbricon]

@angelozerr seems like catalog support is broken in master. Testing the good old IBM examples https://raw.githubusercontent.com/microclimate-devops/xml-language-server/master/client-vscode/xml-client/readme-resources/examples.zip, I get no errors, but that diagnostic that won't go away:

I set

    "xml.catalogs": [
        "catalog/catalog.xml"
    ],

[angelozerr]

The problem comes from cache resolver which is executed before catalog te resolver. More there is à bug with cache when download fails. Validation is triggered every time. Please create an issue, i will fix it and We need tests with cache

[angelozerr]

@ralfhandl I have fixed a bug with catalog. Could you install an upstream of vscode-xml and tell me if it resolves your problem.

If it doesn't resolve it, I will investigate more the problem and try your usecase. Thanks!

[ralfhandl]

@angelozerr I installed http://download.jboss.org/jbosstools/vscode-xml/staging/vscode-xml-0.2.0-467.vsix - however that does not fix the problem.

Not sure if that is what you mean by "upstream", so I followed the instructions in https://github.com/redhat-developer/vscode-xml/blob/master/CONTRIBUTING.md but npm run build-server fails both on plain Windows 10 and on "Linux on Windows".

[angelozerr]

• however that does not fix the problem.

Ok thanks for your feedback, I must find time to study your usecase.I will ping you when if I find and fixes problem.

Not sure if that is what you mean by "upstream"

I meant using last build of vscode-xml, sorry with my bad explanation.

[ralfhandl]

Thanks!

Do you have a working example using a catalog?

[angelozerr]

For our lsp4xml tests, we use https://github.com/angelozerr/lsp4xml/blob/master/org.eclipse.lsp4xml/src/test/resources/catalogs/catalog.xml

[ralfhandl]

Thanks. Can you point me to an XML file that is successfully validated using this catalog.xml?

[angelozerr]

We have not XML file in our test, just string, see for instance https://github.com/angelozerr/lsp4xml/blob/master/org.eclipse.lsp4xml/src/test/java/org/eclipse/lsp4xml/extensions/contentmodel/XMLSchemaDiagnosticsTest.java#L31

[ralfhandl]

All of these tests use xsi:schemaLocation or xsi:noNamespaceSchemaLocation.

Do you have any test case that just relies on the catalog to find the XSD file?

[fbricon]

@ralfhandl you can also use file associations instead, to bind some xml file patterns to schemas, so you don't rely on xsi:schemaLocation or xsi:noNamespaceSchemaLocation.

It'd be easier if you provided a set of sample documents you want to associate (through catalog or other mechanism).

[fbricon]

so I followed the instructions in https://github.com/redhat-developer/vscode-xml/blob/master/CONTRIBUTING.md but npm run build-server fails both on plain Windows 10 and on "Linux on Windows".

@ralfhandl can you please open an issue for that? If you could provide more details about that failure, that'd help.

[angelozerr]

All of these tests use xsi:schemaLocation or xsi:noNamespaceSchemaLocation.

Indeed but they use XML catalog (XML Schema are not loaded from web site).

Do you have any test case that just relies on the catalog to find the XSD file?

I understand that it disturbs you, you can see the test which uses xsi:noNamespaceSchemaLocation="http://invoice.xsd" where this URL doesn't exists an dit uses the XML catalog.

https://github.com/angelozerr/lsp4xml/blob/master/org.eclipse.lsp4xml/src/test/java/org/eclipse/lsp4xml/extensions/contentmodel/XMLSchemaPublishDiagnosticsTest.java#L103