XML Colors feature: Allow custom color format definition

[Lootwig]

A DTD not under my control includes colors specified with tags like

<option name="backgroundColorHex" value="292d3e" />

No prefix there, but as far as I can tell there's no way to make the plugin pick these up without editing the file. Would be a nice addition to allow for a custom setting allowing to transform the captured value, primitive solution by just modifying the string, not sure if there'd be much need for numeric conversion of individual channel values!

[angelozerr]

You mean that you cannot use https://github.com/redhat-developer/vscode-xml/blob/main/docs/Features/XMLColorsFeatures.md ?

[Lootwig]

Only when modifying the document, but I'd prefer being able to work with the format it comes in:

[angelozerr]

I understand your need since you cannot change this format, but I don't see how we could manage custom format. The only solution that I see is ti do that with a Java method, but I am not sure that it is a solution like you want.

[datho7561]

Is this a VS Code limitation or a limitation with our implementation (or both)? Look at this: https://github.com/eclipse-lemminx/lemminx/blob/ab8aa3fa110db899b74eef41c7bd375b60137314/org.eclipse.lemminx/src/main/java/org/eclipse/lemminx/extensions/colors/utils/ColorUtils.java#L339 . We don't recognize hex colours on our end if they don't start with #, but we could try doing that and see what happens.

[angelozerr]

@datho7561 it is not a limitation, since Color is managaed by the language server.

We could indeed ignore the #, but my fear is that some other user want to have another format like using & instead of #

[Lootwig]

@angelozerr well they can open an issue as I did then, can't they? 😆

I forked this repo to look into just creating a PR myself, but I haven't gotten the lemminx dependency to build yet, following the instructions causes an error when trying to fetch maven dependencies from the eclipse repo. Does that not affect anyone else working on this project?

[datho7561]

I forked this repo to look into just creating a PR myself,

I started looking into it as well, but ran out of time for today.

Does that not affect anyone else working on this project?

Hmm Eclipse infrastructure has had issues for the past 2 days, maybe that's related. I haven't noticed anything but the artifacts are probably cached locally for me.

[datho7561]

I got it working locally. The annoying part is that if you use the colour picker it always switches it over to the rgb(126, 126, 126) format, but displaying the colour works.

[Lootwig]

I got it working locally. The annoying part is that if you use the colour picker it always switches it over to the rgb(126, 126, 126) format, but displaying the colour works.

I'll check it out if I can get the local clone to build! ...or if there's a release before then ^^