Validation shows errors in .git files

[Xoechz]

Type: bug

Possible Regression of #861

I tried different Versions and it seems to be broken since 0.27.2.

vscode Info:
Version: 1.98.0
Commit: 6609ac3d66f4eade5cf376d1cb76f13985724bcb
Date: 2025-03-04T21:06:18.612Z
Electron: 34.2.0
ElectronBuildId: 11044223
Chromium: 132.0.6834.196
Node.js: 20.18.2
V8: 13.2.152.36-electron.0
OS: Linux x64 6.12.16

I am currently on NixOS unstable

[angelozerr]

@datho7561 have you some idea of this bug?

[Xoechz]

I found out that #1034 removed the changes from #874

[angelozerr]

Thanks @Xoechz you are right, I didn't remember that I did that :)

It is a very annoying poblem because it seems it is not possible to exclude some scheme with documentSelector. The only solution that I see is to do that somewhere to filter git file with TypeScript :

if (document.uri.scheme === "git") {

[datho7561]

I think we could add some TypeScript to the language client to prevent the validation from being run on files with the .git schema (or maybe we'd have to prevent the open/close events from being sent).

We could also try to do something similar on the server side.

[angelozerr]

I think git files should be ignored, right? I mean hover, completion, etc should not work with git files. If you are OK with that, it means that we must check this git file extension for all LSP features?

[datho7561]

Yes, I think git files should be ignored.

[angelozerr]

My first feeling is that we suffer about documentSelector limitation (we cannot manage exclude), so I wonder if we should use documentSelector like we did before and hard code the unknown scheme streamfile (see #1033 (comment))

[datho7561]

you don't think that filtering out requests on files with git:// in lemminx would work?

[angelozerr]

I think no language server should be started if we have only git files. I think it is the goal of the LSP client which must indicates of language server must be associated with some files and not the server which must takes care of that.

[datho7561]

Right, I forgot about startup. Alright, I think listing all the protocols is a good idea.

[angelozerr]

Glad you are agree with me.

Do you think you could create a PR?

[datho7561]

Sure, I can look into that today